From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64572 invoked by alias); 5 Oct 2017 16:50:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64421 invoked by uid 89); 5 Oct 2017 16:50:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:863 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Oct 2017 16:50:17 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v95GnohF092002 for ; Thu, 5 Oct 2017 12:50:15 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ddp697hp0-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 05 Oct 2017 12:50:15 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 5 Oct 2017 17:50:14 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 5 Oct 2017 17:50:12 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v95GoCKv24183010; Thu, 5 Oct 2017 16:50:12 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B081952041; Thu, 5 Oct 2017 16:44:49 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.152.213.178]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id A0F915203F; Thu, 5 Oct 2017 16:44:49 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 0528CD835F0; Thu, 5 Oct 2017 18:50:12 +0200 (CEST) Subject: Re: [PATCH 3/3] Fix "Remote 'g' packet reply is too long" problems with multiple inferiors To: palves@redhat.com (Pedro Alves) Date: Thu, 05 Oct 2017 16:50:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <1506957311-30028-4-git-send-email-palves@redhat.com> from "Pedro Alves" at Oct 02, 2017 04:15:11 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17100516-0008-0000-0000-0000049CAF06 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17100516-0009-0000-0000-00001E2E1E0D Message-Id: <20171005165012.0528CD835F0@oc3748833570.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-05_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710050233 X-SW-Source: 2017-10/txt/msg00115.txt.bz2 Pedro Alves wrote: > * target.c (default_thread_architecture): Use the sepecified > inferior's architecture, instead of the current inferior's > architecture (via target_gdbarch). This causes a number of ICEs in the test suite for me, at the point when default_thread_architecture is called from linux_child_follow_fork here: if (!gdbarch_software_single_step_p (target_thread_architecture (child_lp->ptid))) Note that at this point there is no inferior for the child, and I think there will never be one since the child is to be detached immediately. Given that this is a fork, I guess a simple fix would be to check for the parent's thread architecture here instead. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com