* [FYI] Remove obsolete assertion from regcache.c
@ 2017-10-17 12:43 Tom Tromey
2017-10-17 12:43 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2017-10-17 12:43 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
When building I got:
../../binutils-gdb/gdb/regcache.c:935:24: error: the address of âssize_t read(int, void*, size_t)â will never be NULL [-Werror=address]
This happens because "read" used to be a parameter to this function,
which was then removed; but the assertion wasn't updated.
I don't think the assertion is relevant any more, to this removes it.
I'm checking it in as obvious.
2017-10-17 Tom Tromey <tom@tromey.com>
* regcache.c (enum register_status): Remove assertion.
---
gdb/ChangeLog | 4 ++++
gdb/regcache.c | 1 -
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 65952c4..8931f36 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2017-10-17 Tom Tromey <tom@tromey.com>
+
+ * regcache.c (enum register_status): Remove assertion.
+
2017-10-17 Pedro Alves <palves@redhat.com>
* xml-support.c (xml_fetch_content_from_file): Call
diff --git a/gdb/regcache.c b/gdb/regcache.c
index 555db57..603d2f2 100644
--- a/gdb/regcache.c
+++ b/gdb/regcache.c
@@ -932,7 +932,6 @@ regcache::xfer_part (int regnum, int offset, int len, void *in,
{
enum register_status status;
- gdb_assert (read != NULL);
if (is_raw)
status = raw_read (regnum, reg);
else
--
2.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FYI] Remove obsolete assertion from regcache.c
2017-10-17 12:43 [FYI] Remove obsolete assertion from regcache.c Tom Tromey
@ 2017-10-17 12:43 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2017-10-17 12:43 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> * regcache.c (enum register_status): Remove assertion.
I fixed the incorrect function name in the ChangeLog first.
Emacs seems to be guessing function names a bit worse lately.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-17 12:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-17 12:43 [FYI] Remove obsolete assertion from regcache.c Tom Tromey
2017-10-17 12:43 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).