From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86109 invoked by alias); 20 Oct 2017 12:51:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86078 invoked by uid 89); 20 Oct 2017 12:51:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Oct 2017 12:51:27 +0000 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v9KCnApl115296 for ; Fri, 20 Oct 2017 08:51:25 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 2dqftknpex-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 20 Oct 2017 08:51:25 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 20 Oct 2017 13:51:23 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 20 Oct 2017 13:51:21 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v9KCpK7I28573790; Fri, 20 Oct 2017 12:51:20 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C2C02AE053; Fri, 20 Oct 2017 13:45:24 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B20F5AE04D; Fri, 20 Oct 2017 13:45:24 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.152.213.178]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 20 Oct 2017 13:45:24 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 577F7D80811; Fri, 20 Oct 2017 14:51:20 +0200 (CEST) Subject: Re: Sporadic failures of selftest tests To: palves@redhat.com (Pedro Alves) Date: Fri, 20 Oct 2017 12:51:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: from "Pedro Alves" at Oct 17, 2017 05:12:16 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17102012-0040-0000-0000-00000404C8C9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17102012-0041-0000-0000-000020A7266A Message-Id: <20171020125120.577F7D80811@oc3748833570.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-20_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710200183 X-SW-Source: 2017-10/txt/msg00660.txt.bz2 Pedro Alves wrote: > Probably the best fix would be to move away from selftest > entirely and convert them to unit tests instead. > > Meanwhile, how about this as an easy fix? We could try > playing games with making functions extern, but maybe > that'd break again with LTO. > > Seems to work for gdb.gdb/selftest.exp and gdb.gdb/complaints.exp > at least. > > (I think we can use __attribute__ directly because > include/ansidecl.h defines it to empty on non-gcc or > older gccs.) > > From: Pedro Alves > Date: 2017-10-17 15:04:11 +0100 > > prevent inlining captured_command_loop Makes sense to me ... Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com