From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] Basic c++ification of varobj
Date: Tue, 21 Nov 2017 21:31:00 -0000 [thread overview]
Message-ID: <20171121213049.4h5tuq64wakvk6jv@localhost> (raw)
In-Reply-To: <20171118214606.24468-2-simon.marchi@polymtl.ca>
On 17-11-18 16:46:03, Simon Marchi wrote:
>
> /* If 1, the -var-update always recomputes the value in the
> current thread and frame. Otherwise, variable object is
> always updated in the specific scope/thread/frame. */
> - int floating;
> + int floating = 0;
>
> /* Flag that indicates validity: set to 0 when this varobj_root refers
> to symbols that do not exist anymore. */
> - int is_valid;
> + int is_valid = 1;
Since we do the change, can we change these fields to bool?
> @@ -114,27 +113,27 @@ struct varobj_dynamic
> used to decide if dynamic varobj should recompute their children.
> In the event that the frontend never asked for the children, we
> can avoid that. */
> - int children_requested;
> + int children_requested = 0;
>
Likewise. Otherwise, it is good to me.
--
Yao
next prev parent reply other threads:[~2017-11-21 21:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 21:46 [PATCH 0/4] C++ify varobj a little bit Simon Marchi
2017-11-18 21:46 ` [PATCH 3/4] Replace VEC (varobj_update_result) with std::vector Simon Marchi
2017-11-18 21:46 ` [PATCH 4/4] Remove DEF_VEC_P (varobj_p) Simon Marchi
2017-11-18 21:46 ` [PATCH 2/4] Make varobj::children an std::vector Simon Marchi
2017-11-18 21:57 ` [PATCH 1/4] Basic c++ification of varobj Simon Marchi
2017-11-21 21:31 ` Yao Qi [this message]
2017-11-22 20:04 ` Simon Marchi
2017-11-22 10:44 ` Pedro Alves
2017-11-22 20:05 ` Simon Marchi
2017-11-21 21:36 ` [PATCH 0/4] C++ify varobj a little bit Yao Qi
2017-11-22 20:10 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121213049.4h5tuq64wakvk6jv@localhost \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).