From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54665 invoked by alias); 12 Dec 2017 15:38:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54653 invoked by uid 89); 12 Dec 2017 15:38:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=learn X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Dec 2017 15:38:19 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4CA54C0753C9; Tue, 12 Dec 2017 15:38:18 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-117-202.ams2.redhat.com [10.36.117.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B8D56C21A; Tue, 12 Dec 2017 15:38:16 +0000 (UTC) Date: Tue, 12 Dec 2017 15:38:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Eli Zaretskii , gdb-patches@sourceware.org, vleschuk@accesssoftek.com Subject: Re: [PATCH v3.2 2/5] DWARF-5: .debug_names index producer Message-ID: <20171212153812.GA6536@host1.jankratochvil.net> References: <149790572259.20186.14601775821404892582.stgit@host1.jankratochvil.net> <149790574432.20186.16599093068806909362.stgit@host1.jankratochvil.net> <83d19ywuuw.fsf@gnu.org> <20170622183542.GA8552@host1.jankratochvil.net> <83h8z7vnl6.fsf@gnu.org> <20170622200344.GA14233@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-SW-Source: 2017-12/txt/msg00276.txt.bz2 On Sat, 09 Dec 2017 00:51:38 +0100, Pedro Alves wrote: > When I started looking at this in detail this week, I was > a bit surprised to learn that the names table is essentially the > same as .gdb_index's, meaning full-qualified names with no > overload/parameter info, and especially -- no indication > of which language the name is for, which was a nuisance > for making C++ wildmatching support work with .gdb_index. > Somehow I had the impression that it was different from > earlier chats. OTOH, the upside is that that we'll manage > to reuse the mapped_index::name_components code for .debug_names. The features of splitting the components of fully qualified names was planned as an add-on patch on top of this one. Although GDB did not have real support for that when I was writing this patchset and I expected it would be then written more as a part of that components support even for the .debug_names index. The goal of the initial .debug_names implementation was to match .gdb_index. > > + if (to_underlying (per_cu.sect_off) >= (static_cast (1) << 32)) > > + return true; > > These look like always return false, since per_cu.sect_off is 32-bit? > I've left it as is, but it doesn't look right to me. Seems like > that makes all the 64-bit support dead as is. I did not know GDB does not support 64-bit DWARF now: /* * Offset relative to the start of its .debug_info or .debug_types section. */ DEFINE_OFFSET_TYPE (sect_offset, unsigned int); Jan