From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88703 invoked by alias); 14 Dec 2017 02:51:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88693 invoked by uid 89); 14 Dec 2017 02:51:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Dec 2017 02:51:12 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 61238116E5F; Wed, 13 Dec 2017 21:51:11 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 51c3JGguj-P4; Wed, 13 Dec 2017 21:51:11 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F1C7B116E5B; Wed, 13 Dec 2017 21:51:10 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 6621789D47; Thu, 14 Dec 2017 06:51:06 +0400 (+04) Date: Thu, 14 Dec 2017 02:51:00 -0000 From: Joel Brobecker To: Stafford Horne Cc: GDB patches Subject: Re: [PATCH] gdb: Fix ARI warnings in or1k-tdep.c Message-ID: <20171214025106.o4kyh2vkql7ehwpx@adacore.com> References: <20171213132654.19739-1-shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213132654.19739-1-shorne@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2017-12/txt/msg00331.txt.bz2 Hello, A very minor thing: > diff --git a/gdb/or1k-tdep.c b/gdb/or1k-tdep.c > index 54b365e958..06ee53e83c 100644 > --- a/gdb/or1k-tdep.c > +++ b/gdb/or1k-tdep.c > @@ -132,7 +132,7 @@ or1k_analyse_inst (uint32_t inst, const char *format, ...) > > /* Check we got something, and if so skip on. */ > if (start_ptr == end_ptr) > - error ("bitstring \"%s\" at offset %d has no length field.\n", > + error (_("bitstring \"%s\" at offset %d has no length field."), > format, i); The second line in the error looks over indented to me. I think it ought to be aligned with the other arguments on the first line: error (_("bitstring \"%s\" at offset %d has no length field."), format, i); (I think I saw about 3 instances of the same alignment issue) -- Joel