public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: GDB patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: Fix ARI warnings in or1k-tdep.c
Date: Thu, 14 Dec 2017 05:42:00 -0000	[thread overview]
Message-ID: <20171214054244.GA32243@lianli.shorne-pla.net> (raw)
In-Reply-To: <20171214025106.o4kyh2vkql7ehwpx@adacore.com>

On Thu, Dec 14, 2017 at 06:51:06AM +0400, Joel Brobecker wrote:
> Hello,
> 
> A very minor thing:
> 
> > diff --git a/gdb/or1k-tdep.c b/gdb/or1k-tdep.c
> > index 54b365e958..06ee53e83c 100644
> > --- a/gdb/or1k-tdep.c
> > +++ b/gdb/or1k-tdep.c
> > @@ -132,7 +132,7 @@ or1k_analyse_inst (uint32_t inst, const char *format, ...)
> >  
> >  	  /* Check we got something, and if so skip on.  */
> >  	  if (start_ptr == end_ptr)
> > -	    error ("bitstring \"%s\" at offset %d has no length field.\n",
> > +	    error (_("bitstring \"%s\" at offset %d has no length field."),
> >  			format, i);
> 
> The second line in the error looks over indented to me. I think
> it ought to be aligned with the other arguments on the first line:
> 
> 	    error (_("bitstring \"%s\" at offset %d has no length field."),
> 		   format, i);
> 
> (I think I saw about 3 instances of the same alignment issue)

Understood, I didnt notice those.  Will fix, I have a few other patches to send.

-Stafford

      reply	other threads:[~2017-12-14  5:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13 13:27 Stafford Horne
2017-12-13 14:42 ` Simon Marchi
2017-12-14  2:51 ` Joel Brobecker
2017-12-14  5:42   ` Stafford Horne [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171214054244.GA32243@lianli.shorne-pla.net \
    --to=shorne@gmail.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).