* [PATCH 0/4] OpenRISC misc updates @ 2017-12-14 6:14 Stafford Horne 2017-12-14 6:14 ` [PATCH 1/4] gdb: Add Stafford Horne as or1k maintainer Stafford Horne ` (3 more replies) 0 siblings, 4 replies; 13+ messages in thread From: Stafford Horne @ 2017-12-14 6:14 UTC (permalink / raw) To: GDB patches; +Cc: Stafford Horne Hi All, This is a series of a few misc patches for gdb and sim now that the or1k port is upstream. The paramater alignment updates are from some late whitespace issues pointed out by Joel. -Stafford Stafford Horne (4): gdb: Add Stafford Horne as or1k maintainer. sim: Add Stafford Horne as or1k maintainer. gdb: Add news entries for new or1k target. gdb: Fix function parameter alignments in or1k-tdep.c. gdb/MAINTAINERS | 3 +++ gdb/NEWS | 4 ++++ gdb/or1k-tdep.c | 18 +++++++++--------- sim/MAINTAINERS | 1 + 4 files changed, 17 insertions(+), 9 deletions(-) -- 2.13.6 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/4] gdb: Add Stafford Horne as or1k maintainer. 2017-12-14 6:14 [PATCH 0/4] OpenRISC misc updates Stafford Horne @ 2017-12-14 6:14 ` Stafford Horne 2017-12-26 13:53 ` Stafford Horne 2017-12-14 6:14 ` [PATCH 3/4] gdb: Add news entries for new or1k target Stafford Horne ` (2 subsequent siblings) 3 siblings, 1 reply; 13+ messages in thread From: Stafford Horne @ 2017-12-14 6:14 UTC (permalink / raw) To: GDB patches; +Cc: Stafford Horne Since I helped upstream openrisc I would like to claim responsibility to maintain it. gdb/ChangeLog: yyyy-mm-dd Stafford Horne <shorne@gmail.com> * (Responsible Maintainers): Add myself as or1k maintainer. --- gdb/MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS index 4597972464..9f61d8dcfa 100644 --- a/gdb/MAINTAINERS +++ b/gdb/MAINTAINERS @@ -290,6 +290,9 @@ the native maintainer when resolving ABI issues. ns32k Deleted + or1k --target=or1k-elf ,-Werror + Stafford Horne shorne@gmail.com + pa --target=hppa-elf ,-Werror powerpc --target=powerpc-eabi ,-Werror -- 2.13.6 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/4] gdb: Add Stafford Horne as or1k maintainer. 2017-12-14 6:14 ` [PATCH 1/4] gdb: Add Stafford Horne as or1k maintainer Stafford Horne @ 2017-12-26 13:53 ` Stafford Horne 2018-06-01 17:24 ` Simon Marchi 0 siblings, 1 reply; 13+ messages in thread From: Stafford Horne @ 2017-12-26 13:53 UTC (permalink / raw) To: GDB patches; +Cc: Stafford Horne Hello, Is this ok to commit? On Thu, Dec 14, 2017 at 3:13 PM, Stafford Horne <shorne@gmail.com> wrote: > Since I helped upstream openrisc I would like to claim responsibility to > maintain it. > > gdb/ChangeLog: > > yyyy-mm-dd Stafford Horne <shorne@gmail.com> > > * (Responsible Maintainers): Add myself as or1k maintainer. > --- > gdb/MAINTAINERS | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS > index 4597972464..9f61d8dcfa 100644 > --- a/gdb/MAINTAINERS > +++ b/gdb/MAINTAINERS > @@ -290,6 +290,9 @@ the native maintainer when resolving ABI issues. > > ns32k Deleted > > + or1k --target=or1k-elf ,-Werror > + Stafford Horne shorne@gmail.com > + > pa --target=hppa-elf ,-Werror > > powerpc --target=powerpc-eabi ,-Werror > -- > 2.13.6 > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/4] gdb: Add Stafford Horne as or1k maintainer. 2017-12-26 13:53 ` Stafford Horne @ 2018-06-01 17:24 ` Simon Marchi 2018-06-03 3:26 ` Stafford Horne 0 siblings, 1 reply; 13+ messages in thread From: Simon Marchi @ 2018-06-01 17:24 UTC (permalink / raw) To: Stafford Horne, GDB patches On 2017-12-26 08:53 AM, Stafford Horne wrote: > Hello, > > Is this ok to commit? > > On Thu, Dec 14, 2017 at 3:13 PM, Stafford Horne <shorne@gmail.com> wrote: >> Since I helped upstream openrisc I would like to claim responsibility to >> maintain it. >> >> gdb/ChangeLog: >> >> yyyy-mm-dd Stafford Horne <shorne@gmail.com> >> >> * (Responsible Maintainers): Add myself as or1k maintainer. >> --- >> gdb/MAINTAINERS | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS >> index 4597972464..9f61d8dcfa 100644 >> --- a/gdb/MAINTAINERS >> +++ b/gdb/MAINTAINERS >> @@ -290,6 +290,9 @@ the native maintainer when resolving ABI issues. >> >> ns32k Deleted >> >> + or1k --target=or1k-elf ,-Werror >> + Stafford Horne shorne@gmail.com >> + >> pa --target=hppa-elf ,-Werror >> >> powerpc --target=powerpc-eabi ,-Werror >> -- >> 2.13.6 >> Hi Stafford, The other day when looking at the or1k-tdep.o/--enable-targets=all thing, I dug in the original submission patchsets and found that this had been overlooked. I think it makes perfect sense to have you as the or1k maintainer, it was certainly not intentional to ignore this. So please push, and apologies for the delay! Simon ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/4] gdb: Add Stafford Horne as or1k maintainer. 2018-06-01 17:24 ` Simon Marchi @ 2018-06-03 3:26 ` Stafford Horne 0 siblings, 0 replies; 13+ messages in thread From: Stafford Horne @ 2018-06-03 3:26 UTC (permalink / raw) To: Simon Marchi; +Cc: GDB patches On Fri, Jun 01, 2018 at 01:24:04PM -0400, Simon Marchi wrote: > On 2017-12-26 08:53 AM, Stafford Horne wrote: > > Hello, > > > > Is this ok to commit? > > > > On Thu, Dec 14, 2017 at 3:13 PM, Stafford Horne <shorne@gmail.com> wrote: > >> Since I helped upstream openrisc I would like to claim responsibility to > >> maintain it. > >> > >> gdb/ChangeLog: > >> > >> yyyy-mm-dd Stafford Horne <shorne@gmail.com> > >> > >> * (Responsible Maintainers): Add myself as or1k maintainer. > >> --- > >> gdb/MAINTAINERS | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS > >> index 4597972464..9f61d8dcfa 100644 > >> --- a/gdb/MAINTAINERS > >> +++ b/gdb/MAINTAINERS > >> @@ -290,6 +290,9 @@ the native maintainer when resolving ABI issues. > >> > >> ns32k Deleted > >> > >> + or1k --target=or1k-elf ,-Werror > >> + Stafford Horne shorne@gmail.com > >> + > >> pa --target=hppa-elf ,-Werror > >> > >> powerpc --target=powerpc-eabi ,-Werror > >> -- > >> 2.13.6 > >> > > > Hi Stafford, > > The other day when looking at the or1k-tdep.o/--enable-targets=all thing, > I dug in the original submission patchsets and found that this had been > overlooked. I think it makes perfect sense to have you as the or1k > maintainer, it was certainly not intentional to ignore this. > > So please push, and apologies for the delay! Thanks, I will add it soon. -Stafford ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 3/4] gdb: Add news entries for new or1k target. 2017-12-14 6:14 [PATCH 0/4] OpenRISC misc updates Stafford Horne 2017-12-14 6:14 ` [PATCH 1/4] gdb: Add Stafford Horne as or1k maintainer Stafford Horne @ 2017-12-14 6:14 ` Stafford Horne 2017-12-14 17:01 ` Eli Zaretskii 2017-12-14 6:14 ` [PATCH 2/4] sim: Add Stafford Horne as or1k maintainer Stafford Horne 2017-12-14 6:14 ` [PATCH 4/4] gdb: Fix function parameter alignments in or1k-tdep.c Stafford Horne 3 siblings, 1 reply; 13+ messages in thread From: Stafford Horne @ 2017-12-14 6:14 UTC (permalink / raw) To: GDB patches; +Cc: Stafford Horne gdb/ChangeLog: yyyy-mm-dd Stafford Horne <shorne@gmail.com> * NEWS (Changes since GDB 8.0): Mention new or1k target and new commands to set/show or1k debug. --- gdb/NEWS | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/NEWS b/gdb/NEWS index bd5ae36dd0..5d8bc1e9f9 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -207,6 +207,9 @@ maint info selftests starti Start the debugged program stopping at the first instruction. +set|show debug or1k + Control display of debugging messages related to OpenRISC targets. + set|show print type nested-type-limit Set and show the limit of nesting level for nested types that the type printer will show. @@ -249,6 +252,7 @@ FreeBSD/arm arm*-*-freebsd* FreeBSD/aarch64 aarch64*-*-freebsd* FreeBSD/arm arm*-*-freebsd* +OpenRISC ELF or1k*-*-elf * Removed targets and native configurations -- 2.13.6 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/4] gdb: Add news entries for new or1k target. 2017-12-14 6:14 ` [PATCH 3/4] gdb: Add news entries for new or1k target Stafford Horne @ 2017-12-14 17:01 ` Eli Zaretskii 0 siblings, 0 replies; 13+ messages in thread From: Eli Zaretskii @ 2017-12-14 17:01 UTC (permalink / raw) To: Stafford Horne; +Cc: gdb-patches > From: Stafford Horne <shorne@gmail.com> > Cc: Stafford Horne <shorne@gmail.com> > Date: Thu, 14 Dec 2017 15:13:40 +0900 > > gdb/ChangeLog: > > yyyy-mm-dd Stafford Horne <shorne@gmail.com> > > * NEWS (Changes since GDB 8.0): Mention new or1k target and new > commands to set/show or1k debug. OK. ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 2/4] sim: Add Stafford Horne as or1k maintainer. 2017-12-14 6:14 [PATCH 0/4] OpenRISC misc updates Stafford Horne 2017-12-14 6:14 ` [PATCH 1/4] gdb: Add Stafford Horne as or1k maintainer Stafford Horne 2017-12-14 6:14 ` [PATCH 3/4] gdb: Add news entries for new or1k target Stafford Horne @ 2017-12-14 6:14 ` Stafford Horne 2017-12-26 13:53 ` Stafford Horne 2017-12-14 6:14 ` [PATCH 4/4] gdb: Fix function parameter alignments in or1k-tdep.c Stafford Horne 3 siblings, 1 reply; 13+ messages in thread From: Stafford Horne @ 2017-12-14 6:14 UTC (permalink / raw) To: GDB patches; +Cc: Stafford Horne Since I helped upstream the or1k port I would like to claim myself as maintainer. sim/ChangeLog: yyyy-mm-dd Stafford Horne <shorne@gmail.com> * MAINTAINERS (or1k): Add myself as or1k maintainer. --- sim/MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/sim/MAINTAINERS b/sim/MAINTAINERS index 59d23a0f29..729e261f5c 100644 --- a/sim/MAINTAINERS +++ b/sim/MAINTAINERS @@ -30,6 +30,7 @@ microblaze Michael Eager <eager@eagercon.com> mips Maciej W. Rozycki <macro@imgtec.com> moxie Anthony Green <green@moxielogic.com> msp430 Nick Clifton <nickc@redhat.com> +or1k Stafford Horne <shorne@gmail.com> rx DJ Delorie <dj@redhat.com> sh (global maintainers) sh64 Dave Brolley <brolley@redhat.com> -- 2.13.6 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/4] sim: Add Stafford Horne as or1k maintainer. 2017-12-14 6:14 ` [PATCH 2/4] sim: Add Stafford Horne as or1k maintainer Stafford Horne @ 2017-12-26 13:53 ` Stafford Horne 2018-06-01 17:25 ` Simon Marchi 0 siblings, 1 reply; 13+ messages in thread From: Stafford Horne @ 2017-12-26 13:53 UTC (permalink / raw) To: GDB patches; +Cc: Stafford Horne Hello, Is this ok to commit? On Thu, Dec 14, 2017 at 3:13 PM, Stafford Horne <shorne@gmail.com> wrote: > Since I helped upstream the or1k port I would like to claim myself as > maintainer. > > sim/ChangeLog: > > yyyy-mm-dd Stafford Horne <shorne@gmail.com> > > * MAINTAINERS (or1k): Add myself as or1k maintainer. > --- > sim/MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sim/MAINTAINERS b/sim/MAINTAINERS > index 59d23a0f29..729e261f5c 100644 > --- a/sim/MAINTAINERS > +++ b/sim/MAINTAINERS > @@ -30,6 +30,7 @@ microblaze Michael Eager <eager@eagercon.com> > mips Maciej W. Rozycki <macro@imgtec.com> > moxie Anthony Green <green@moxielogic.com> > msp430 Nick Clifton <nickc@redhat.com> > +or1k Stafford Horne <shorne@gmail.com> > rx DJ Delorie <dj@redhat.com> > sh (global maintainers) > sh64 Dave Brolley <brolley@redhat.com> > -- > 2.13.6 > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/4] sim: Add Stafford Horne as or1k maintainer. 2017-12-26 13:53 ` Stafford Horne @ 2018-06-01 17:25 ` Simon Marchi 2018-06-03 3:29 ` Stafford Horne 0 siblings, 1 reply; 13+ messages in thread From: Simon Marchi @ 2018-06-01 17:25 UTC (permalink / raw) To: Stafford Horne, GDB patches, Mike Frysinger On 2017-12-26 08:53 AM, Stafford Horne wrote: > Hello, > > Is this ok to commit? > > On Thu, Dec 14, 2017 at 3:13 PM, Stafford Horne <shorne@gmail.com> wrote: >> Since I helped upstream the or1k port I would like to claim myself as >> maintainer. >> >> sim/ChangeLog: >> >> yyyy-mm-dd Stafford Horne <shorne@gmail.com> >> >> * MAINTAINERS (or1k): Add myself as or1k maintainer. >> --- >> sim/MAINTAINERS | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/sim/MAINTAINERS b/sim/MAINTAINERS >> index 59d23a0f29..729e261f5c 100644 >> --- a/sim/MAINTAINERS >> +++ b/sim/MAINTAINERS >> @@ -30,6 +30,7 @@ microblaze Michael Eager <eager@eagercon.com> >> mips Maciej W. Rozycki <macro@imgtec.com> >> moxie Anthony Green <green@moxielogic.com> >> msp430 Nick Clifton <nickc@redhat.com> >> +or1k Stafford Horne <shorne@gmail.com> >> rx DJ Delorie <dj@redhat.com> >> sh (global maintainers) >> sh64 Dave Brolley <brolley@redhat.com> >> -- >> 2.13.6 >> Hi Mike, Could you please consider this patch that adds Stafford as the or1k maintainer for sim/? Thanks, Simon ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/4] sim: Add Stafford Horne as or1k maintainer. 2018-06-01 17:25 ` Simon Marchi @ 2018-06-03 3:29 ` Stafford Horne 0 siblings, 0 replies; 13+ messages in thread From: Stafford Horne @ 2018-06-03 3:29 UTC (permalink / raw) To: Simon Marchi; +Cc: GDB patches, Mike Frysinger On Fri, Jun 01, 2018 at 01:24:57PM -0400, Simon Marchi wrote: > On 2017-12-26 08:53 AM, Stafford Horne wrote: > > Hello, > > > > Is this ok to commit? > > > > On Thu, Dec 14, 2017 at 3:13 PM, Stafford Horne <shorne@gmail.com> wrote: > >> Since I helped upstream the or1k port I would like to claim myself as > >> maintainer. > >> > >> sim/ChangeLog: > >> > >> yyyy-mm-dd Stafford Horne <shorne@gmail.com> > >> > >> * MAINTAINERS (or1k): Add myself as or1k maintainer. > >> --- > >> sim/MAINTAINERS | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/sim/MAINTAINERS b/sim/MAINTAINERS > >> index 59d23a0f29..729e261f5c 100644 > >> --- a/sim/MAINTAINERS > >> +++ b/sim/MAINTAINERS > >> @@ -30,6 +30,7 @@ microblaze Michael Eager <eager@eagercon.com> > >> mips Maciej W. Rozycki <macro@imgtec.com> > >> moxie Anthony Green <green@moxielogic.com> > >> msp430 Nick Clifton <nickc@redhat.com> > >> +or1k Stafford Horne <shorne@gmail.com> > >> rx DJ Delorie <dj@redhat.com> > >> sh (global maintainers) > >> sh64 Dave Brolley <brolley@redhat.com> > >> -- > >> 2.13.6 > >> > > Hi Mike, > > Could you please consider this patch that adds Stafford as the or1k maintainer > for sim/? Hello, I haven't seen any replies from Mike related to gdb or sim for a year or so. If no one objects I will submit this in a day or so. -Stafford ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 4/4] gdb: Fix function parameter alignments in or1k-tdep.c. 2017-12-14 6:14 [PATCH 0/4] OpenRISC misc updates Stafford Horne ` (2 preceding siblings ...) 2017-12-14 6:14 ` [PATCH 2/4] sim: Add Stafford Horne as or1k maintainer Stafford Horne @ 2017-12-14 6:14 ` Stafford Horne 2017-12-15 10:48 ` Yao Qi 3 siblings, 1 reply; 13+ messages in thread From: Stafford Horne @ 2017-12-14 6:14 UTC (permalink / raw) To: GDB patches; +Cc: Stafford Horne As suggested by Joel Brobecker <brobecker@adacore.com> and as per fsf coding standards. Also fix a few more issues with directly printing pointers. gdb/ChangeLog: yyyy-mm-dd Stafford Horne <shorne@gmail.com> * gdb/or1k-tdep.c (show_or1k_debug): Fix function parameter alignment. (or1k_analyse_inst): Likewise. (or1k_single_step_through_delay): Likewise. (or1k_frame_cache): Fix parameter alignment and use paddress() instead of %x. --- gdb/or1k-tdep.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/gdb/or1k-tdep.c b/gdb/or1k-tdep.c index 06ee53e83c..a8de029997 100644 --- a/gdb/or1k-tdep.c +++ b/gdb/or1k-tdep.c @@ -55,7 +55,7 @@ static int or1k_debug = 0; static void show_or1k_debug (struct ui_file *file, int from_tty, - struct cmd_list_element *c, const char *value) + struct cmd_list_element *c, const char *value) { fprintf_filtered (file, _("OpenRISC debugging is %s.\n"), value); } @@ -133,7 +133,7 @@ or1k_analyse_inst (uint32_t inst, const char *format, ...) /* Check we got something, and if so skip on. */ if (start_ptr == end_ptr) error (_("bitstring \"%s\" at offset %d has no length field."), - format, i); + format, i); i += end_ptr - start_ptr; @@ -142,7 +142,7 @@ or1k_analyse_inst (uint32_t inst, const char *format, ...) just should not be wrong. */ if ('b' != format[i++]) error (_("bitstring \"%s\" at offset %d has no terminating 'b'."), - format, i); + format, i); /* Break out the field. There is a special case with a bit width of 32. */ @@ -159,7 +159,7 @@ or1k_analyse_inst (uint32_t inst, const char *format, ...) default: error (_("invalid character in bitstring \"%s\" at offset %d."), - format, i); + format, i); break; } } @@ -372,9 +372,9 @@ or1k_single_step_through_delay (struct gdbarch *gdbarch, return 0; insn = cgen_lookup_insn (tdep->gdb_cgen_cpu_desc, - NULL, - or1k_fetch_instruction (gdbarch, ppc), - NULL, 32, &tmp_fields, 0); + NULL, + or1k_fetch_instruction (gdbarch, ppc), + NULL, 32, &tmp_fields, 0); /* NULL here would mean the last instruction was not understood by cgen. This should not usually happen, but if does its not a delay slot. */ @@ -942,8 +942,8 @@ or1k_frame_cache (struct frame_info *this_frame, void **prologue_cache) have executed the code. Check we have a sane prologue size, and if zero we are frameless and can give up here. */ if (end_addr < start_addr) - error (_("end addr 0x%08x is less than start addr 0x%08x"), - (unsigned int) end_addr, (unsigned int) start_addr); + error (_("end addr %s is less than start addr %s"), + paddress (gdbarch, end_addr), paddress (gdbarch, start_addr)); if (end_addr == start_addr) frame_size = 0; -- 2.13.6 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4/4] gdb: Fix function parameter alignments in or1k-tdep.c. 2017-12-14 6:14 ` [PATCH 4/4] gdb: Fix function parameter alignments in or1k-tdep.c Stafford Horne @ 2017-12-15 10:48 ` Yao Qi 0 siblings, 0 replies; 13+ messages in thread From: Yao Qi @ 2017-12-15 10:48 UTC (permalink / raw) To: Stafford Horne; +Cc: GDB patches Stafford Horne <shorne@gmail.com> writes: > yyyy-mm-dd Stafford Horne <shorne@gmail.com> > > * gdb/or1k-tdep.c (show_or1k_debug): Fix function parameter alignment. > (or1k_analyse_inst): Likewise. > (or1k_single_step_through_delay): Likewise. > (or1k_frame_cache): Fix parameter alignment and use paddress() > instead of %x. Patch is good to me, please apply. -- Yao (齐尧) ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-06-03 3:29 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-12-14 6:14 [PATCH 0/4] OpenRISC misc updates Stafford Horne 2017-12-14 6:14 ` [PATCH 1/4] gdb: Add Stafford Horne as or1k maintainer Stafford Horne 2017-12-26 13:53 ` Stafford Horne 2018-06-01 17:24 ` Simon Marchi 2018-06-03 3:26 ` Stafford Horne 2017-12-14 6:14 ` [PATCH 3/4] gdb: Add news entries for new or1k target Stafford Horne 2017-12-14 17:01 ` Eli Zaretskii 2017-12-14 6:14 ` [PATCH 2/4] sim: Add Stafford Horne as or1k maintainer Stafford Horne 2017-12-26 13:53 ` Stafford Horne 2018-06-01 17:25 ` Simon Marchi 2018-06-03 3:29 ` Stafford Horne 2017-12-14 6:14 ` [PATCH 4/4] gdb: Fix function parameter alignments in or1k-tdep.c Stafford Horne 2017-12-15 10:48 ` Yao Qi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).