Re: [PATCH v3 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p

[Stafford Horne <shorne@gmail.com>]

On Tue, Dec 19, 2017 at 06:27:33PM +0200, Eli Zaretskii wrote:
> > From: Stafford Horne <shorne@gmail.com>
> > Cc: Openrisc <openrisc@lists.librecores.org>,	Stafford Horne <shorne@gmail.com>
> > diff --git a/gdb/NEWS b/gdb/NEWS
> > index 44f481d1f5..7d27262aee 100644
> > --- a/gdb/NEWS
> > +++ b/gdb/NEWS
> > @@ -3,6 +3,13 @@
> >  
> >  *** Changes since GDB 8.0
> >  
> > +* GDB now supports dynamically creating arbitrary register groups specified
> > +  in XML target descriptions.  This allows for finer grain grouping of
> > +  registers on systems with a large amount of registers.
> > +
> > +* On Unix systems, GDBserver now does globbing expansion and variable
> > +  substitution in inferior command line arguments.
> 
> The second paragraph doesn't belong to this changeset, right?

Right, I accidently brought this in during conflict resolution.  Will fix.

> >  @item group
> > -The register group to which this register belongs.  It must
> > -be either @code{general}, @code{float}, or @code{vector}.  If no
> > -@var{group} is specified, @value{GDBN} will not display the register
> > -in @code{info registers}.
> > +The register group to which this register belongs.  It can be one of the
> > +standard register groups @code{general}, @code{float}, @code{vector} or an
> > +arbitrary string.  The string should be limited to alphanumeric characters
> > +and internal hyphens.  If no @var{group} is specified, @value{GDBN} will
> 
> What do you mean by "internal hyphens"?

This means, hyphens withing the register group name, not starting or ending with
hyphens.  (i.e. special-spr,  but not rg1- or -rg2)

-Stafford

> Thanks.