From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13649 invoked by alias); 20 Dec 2017 13:35:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13596 invoked by uid 89); 20 Dec 2017 13:34:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f176.google.com Received: from mail-pf0-f176.google.com (HELO mail-pf0-f176.google.com) (209.85.192.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Dec 2017 13:34:58 +0000 Received: by mail-pf0-f176.google.com with SMTP id e3so12559327pfi.10 for ; Wed, 20 Dec 2017 05:34:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IyexVM68w+rad0pv01FqOoNk6nM/ZVM5KG8cpAD59kY=; b=XzN5qZz9n+e7WQxQLf6YLNGNYdfi1XXeDyAabrgKcUiv84Q+aDqFNKa+fmsre/aX25 geECVwtFyyqogCyA37aeiDu7PyMAP0dkJS8QEHx15Pocrr3CHTcsrCodIX1kfosqnoBe u4uIkbjrJXuGdr6FTbIws2ERlNbY348uwViSsOoNTBMvErrY7zsGq4WeWsAx7vPIfO3O 2kN8PhuMxFg+Wjl4KEQga8JYEVFdnUD8SWg+7XGG4iKY0xWSx6kvSLu8HpmP5ejO5hW5 jBbHb0TMD21Cj8Sde9OSHIzLL3jw8Br2ZkR3JPEDxUYUp8xM+L+ERslw/5NKR74uAZzC qplg== X-Gm-Message-State: AKGB3mLZydOyMfUGXjCJjA0KtT3mNHtTe8s0YJgzT+IFSqKaRqLXaaBc O2lKGcejoSCQVcZ3MiC2yIiiOhpD X-Google-Smtp-Source: ACJfBotucHlI699YeUGOj67GHYA4SD/EQHcPEww3dEOxK2a2GPMqpgF8AkvFwF5vaoDRTlhywu5EvQ== X-Received: by 10.101.90.199 with SMTP id d7mr6226141pgt.265.1513776896240; Wed, 20 Dec 2017 05:34:56 -0800 (PST) Received: from localhost (g128.222-224-187.ppp.wakwak.ne.jp. [222.224.187.128]) by smtp.gmail.com with ESMTPSA id k23sm35792448pfj.22.2017.12.20.05.34.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Dec 2017 05:34:55 -0800 (PST) Date: Wed, 20 Dec 2017 13:35:00 -0000 From: Stafford Horne To: Eli Zaretskii Cc: gdb-patches@sourceware.org, openrisc@lists.librecores.org Subject: Re: [PATCH v3 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p Message-ID: <20171220133454.GD32243@lianli.shorne-pla.net> References: <20171219142257.13402-1-shorne@gmail.com> <20171219142257.13402-5-shorne@gmail.com> <836092ptsa.fsf@gnu.org> <20171219221300.GB32243@lianli.shorne-pla.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171219221300.GB32243@lianli.shorne-pla.net> User-Agent: Mutt/1.9.1 (2017-09-22) X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00450.txt.bz2 Hi Eli On Wed, Dec 20, 2017 at 07:13:00AM +0900, Stafford Horne wrote: > On Tue, Dec 19, 2017 at 06:27:33PM +0200, Eli Zaretskii wrote: > > > From: Stafford Horne > > > Cc: Openrisc , Stafford Horne > > > diff --git a/gdb/NEWS b/gdb/NEWS > > > index 44f481d1f5..7d27262aee 100644 > > > --- a/gdb/NEWS > > > +++ b/gdb/NEWS > > > @@ -3,6 +3,13 @@ > > > > > > *** Changes since GDB 8.0 > > > > > > +* GDB now supports dynamically creating arbitrary register groups specified > > > + in XML target descriptions. This allows for finer grain grouping of > > > + registers on systems with a large amount of registers. > > > + > > > +* On Unix systems, GDBserver now does globbing expansion and variable > > > + substitution in inferior command line arguments. > > > > The second paragraph doesn't belong to this changeset, right? > > Right, I accidently brought this in during conflict resolution. Will fix. > > > > @item group > > > -The register group to which this register belongs. It must > > > -be either @code{general}, @code{float}, or @code{vector}. If no > > > -@var{group} is specified, @value{GDBN} will not display the register > > > -in @code{info registers}. > > > +The register group to which this register belongs. It can be one of the > > > +standard register groups @code{general}, @code{float}, @code{vector} or an > > > +arbitrary string. The string should be limited to alphanumeric characters > > > +and internal hyphens. If no @var{group} is specified, @value{GDBN} will > > > > What do you mean by "internal hyphens"? > > This means, hyphens withing the register group name, not starting or ending with > hyphens. (i.e. special-spr, but not rg1- or -rg2) I looked a bit into this, I seem to have pulled this text from the target-descriptions.c file. The line saying ".. and internal hyphens" was added as a comment in 2007 in commit 123dc839145 by Daniel Jacobowitz. The commit was the introduction of the target descriptions code. I don't see any actual enforcement of the name format. I can leave that whole sentence out. But I think its useful to mention as it is the intended format. I could change it to say something like "alphanumeric characters and hyphens as word separators." or "The group name should be limited to hyphen-separated alphanumeric strings." -Stafford