From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org, Keith Seitz <keiths@redhat.com>,
Xavier Roirand <roirand@adacore.com>
Subject: Re: [RFA/linespec] wrong line number in breakpoint location
Date: Thu, 21 Dec 2017 11:31:00 -0000 [thread overview]
Message-ID: <20171221113127.ijqv6dnzjfifwfnb@adacore.com> (raw)
In-Reply-To: <206d75d6b1f14e55b6a0dff523d8c722@polymtl.ca>
> > /* The following function's implementation starts by including a file
> > (break-include.inc) which contains a copyright header followed by
> > a single C statement. When we break on the line where the function
>
> I would say "place a breakpoint" instead of break. For me "to break" is the
> action of the program stopping on a breakpoint (though maybe it
Sounds good.
Here is a new version :). I also noticed I forgot the gdb.base/
subdir in the name of the new files in the testsuite, so I fixed
that up too.
gdb/ChangeLog:
* linespec.c (create_sals_line_offset): Remove code that preserved
the symtab_and_line's line number.
gdb/testsuite/ChangeLog:
* gdb.base/break-include.c, gdb.base/break-include.inc,
gdb.base/break-include.exp: New files.
* gdb.base/ending-run.exp: Minor adaptations due to the breakpoint's
line number now being the actual line number where the breakpoint
was inserted.
* gdb.mi/mi-break.exp: Likewise.
* gdb.mi/mi-reverse.exp: Likewise.
* gdb.mi/mi-simplerun.exp: Ditto.
Thanks,
--
Joel
next prev parent reply other threads:[~2017-12-21 11:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 2:44 Joel Brobecker
2017-12-18 4:09 ` Simon Marchi
2017-12-19 9:24 ` Joel Brobecker
2017-12-21 1:31 ` Simon Marchi
2017-12-21 11:31 ` Joel Brobecker [this message]
2017-12-21 11:32 ` Joel Brobecker
2018-01-22 4:17 ` pushed: " Joel Brobecker
2018-01-26 17:16 ` Simon Marchi
2018-01-29 4:45 ` Joel Brobecker
2018-01-29 17:01 ` Simon Marchi
2018-01-30 4:09 ` Joel Brobecker
2018-01-30 12:39 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221113127.ijqv6dnzjfifwfnb@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=roirand@adacore.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).