From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41398 invoked by alias); 21 Dec 2017 11:31:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41346 invoked by uid 89); 21 Dec 2017 11:31:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1090, adaptations X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Dec 2017 11:31:34 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id EEA731171AC; Thu, 21 Dec 2017 06:31:32 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id cvq5-b70c0PL; Thu, 21 Dec 2017 06:31:32 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 81A44117127; Thu, 21 Dec 2017 06:31:32 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B7E67809B4; Thu, 21 Dec 2017 15:31:27 +0400 (+04) Date: Thu, 21 Dec 2017 11:31:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org, Keith Seitz , Xavier Roirand Subject: Re: [RFA/linespec] wrong line number in breakpoint location Message-ID: <20171221113127.ijqv6dnzjfifwfnb@adacore.com> References: <1513565091-118926-1-git-send-email-brobecker@adacore.com> <20171219092405.n2dql5ji52qhjilj@adacore.com> <206d75d6b1f14e55b6a0dff523d8c722@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <206d75d6b1f14e55b6a0dff523d8c722@polymtl.ca> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2017-12/txt/msg00468.txt.bz2 > > /* The following function's implementation starts by including a file > > (break-include.inc) which contains a copyright header followed by > > a single C statement. When we break on the line where the function > > I would say "place a breakpoint" instead of break. For me "to break" is the > action of the program stopping on a breakpoint (though maybe it Sounds good. Here is a new version :). I also noticed I forgot the gdb.base/ subdir in the name of the new files in the testsuite, so I fixed that up too. gdb/ChangeLog: * linespec.c (create_sals_line_offset): Remove code that preserved the symtab_and_line's line number. gdb/testsuite/ChangeLog: * gdb.base/break-include.c, gdb.base/break-include.inc, gdb.base/break-include.exp: New files. * gdb.base/ending-run.exp: Minor adaptations due to the breakpoint's line number now being the actual line number where the breakpoint was inserted. * gdb.mi/mi-break.exp: Likewise. * gdb.mi/mi-reverse.exp: Likewise. * gdb.mi/mi-simplerun.exp: Ditto. Thanks, -- Joel