[PATCH 4/5] gdb/copyright.py: Remove testsuite/gdb.base/step-line.{c,inp} special handling

[PATCH 4/5] gdb/copyright.py: Remove testsuite/gdb.base/step-line.{c,inp} special handling

[Joel Brobecker]

In the past, these files needed to be handled by hand, because
the testcase was sensitive to the length of the header, which was
potentially changing when new copyright years were added to
the copyright header. Now that we simply maintain and update
a range, the length of the copyright header should not change
as a consequence of the update performed by this script, so
special handling of those files is no longer necessary.

gdb/ChangeLog:

        * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
        and gdb/testsuite/gdb.base/step-line.c.
---
 gdb/ChangeLog    | 5 +++++
 gdb/copyright.py | 4 +---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 27f7c7ffee..96cc88d658 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
 
+	* copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
+	and gdb/testsuite/gdb.base/step-line.c.
+
+2018-01-01  Joel Brobecker  <brobecker@adacore.com>
+
 	* copyright.py (main): Dump the contents of
 	MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
 	even if BY_HAND is empty.
diff --git a/gdb/copyright.py b/gdb/copyright.py
index bb21b21601..119f69f9e3 100644
--- a/gdb/copyright.py
+++ b/gdb/copyright.py
@@ -200,9 +200,7 @@ EXCLUDE_ALL_LIST = (
 
 # The list of files to update by hand.
 BY_HAND = (
-    # These files are sensitive to line numbering.
-    "gdb/testsuite/gdb.base/step-line.inp",
-    "gdb/testsuite/gdb.base/step-line.c",
+    # Nothing at the moment :-).
 )
 
 # Files containing multiple copyright headers.  This script is only
-- 
2.11.0

GDB "Start of New Year Procedure" -- 2018 edition

[Joel Brobecker]

Hello,

I am about to push the following commits. Most of them are a direct
application of the "Start of New Year Procedure" procedure listed
in our GDB Internals Manual. A couple of them are tiny adjustments
to the gdb/copyright.sh script to remove the need for a manual update
of a couple of files that can now be processed automatically, and
before that fix a small bug which is hidden until we remove those
the special processing for those two files.

  * [PATCH 1/5] Yearly rotation of the gdb/ChangeLog file
  * [PATCH 2/5] Update copyright year in version message of GDB,
  * [PATCH 3/5] gdb/copyright.py: Do not forget to remind about
  * [PATCH 4/5] gdb/copyright.py: Remove
  * [PATCH 5/5] Update copyright year range in all GDB files

Tested by rebuilding GDB from scratch on x86_64-linux.

Thanks,
-- 
Joel

[PATCH 2/5] Update copyright year in version message of GDB, GDBserver and GDBreplay

[Joel Brobecker]

gdb/ChangeLog:

	* top.c (print_gdb_version): Update Copyright year in version
	message.

gdb/gdbserver/ChangeLog:

	* gdbreplay.c (gdbreplay_version): Update copyright year in
	version message.
	* server.c (gdbserver_version): Likewise.
---
 gdb/ChangeLog             | 5 +++++
 gdb/gdbserver/ChangeLog   | 6 ++++++
 gdb/gdbserver/gdbreplay.c | 2 +-
 gdb/gdbserver/server.c    | 2 +-
 gdb/top.c                 | 2 +-
 5 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 308dceee6a..929c513a78 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
 
+	* top.c (print_gdb_version): Update Copyright year in version
+	message.
+
+2018-01-01  Joel Brobecker  <brobecker@adacore.com>
+
 	* config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
 
 For older changes see ChangeLog-2017.
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index b5667bf1f1..1170a06b04 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,9 @@
+2018-01-01  Joel Brobecker  <brobecker@adacore.com>
+
+	* gdbreplay.c (gdbreplay_version): Update copyright year in
+	version message.
+	* server.c (gdbserver_version): Likewise.
+
 2017-12-08  Tom Tromey  <tom@tromey.com>
 
 	* ax.c (ax_printf): Update.
diff --git a/gdb/gdbserver/gdbreplay.c b/gdb/gdbserver/gdbreplay.c
index b76850617f..a8f3b3d326 100644
--- a/gdb/gdbserver/gdbreplay.c
+++ b/gdb/gdbserver/gdbreplay.c
@@ -407,7 +407,7 @@ static void
 gdbreplay_version (void)
 {
   printf ("GNU gdbreplay %s%s\n"
-	  "Copyright (C) 2017 Free Software Foundation, Inc.\n"
+	  "Copyright (C) 2018 Free Software Foundation, Inc.\n"
 	  "gdbreplay is free software, covered by "
 	  "the GNU General Public License.\n"
 	  "This gdbreplay was configured as \"%s\"\n",
diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c
index e2b75376ee..d86cff86a6 100644
--- a/gdb/gdbserver/server.c
+++ b/gdb/gdbserver/server.c
@@ -3387,7 +3387,7 @@ static void
 gdbserver_version (void)
 {
   printf ("GNU gdbserver %s%s\n"
-	  "Copyright (C) 2017 Free Software Foundation, Inc.\n"
+	  "Copyright (C) 2018 Free Software Foundation, Inc.\n"
 	  "gdbserver is free software, covered by the "
 	  "GNU General Public License.\n"
 	  "This gdbserver was configured as \"%s\"\n",
diff --git a/gdb/top.c b/gdb/top.c
index 3fb113c381..e2aa8849da 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -1292,7 +1292,7 @@ print_gdb_version (struct ui_file *stream)
   /* Second line is a copyright notice.  */
 
   fprintf_filtered (stream,
-		    "Copyright (C) 2017 Free Software Foundation, Inc.\n");
+		    "Copyright (C) 2018 Free Software Foundation, Inc.\n");
 
   /* Following the copyright is a brief statement that the program is
      free software, that users are free to copy and change it on
-- 
2.11.0

[PATCH 3/5] gdb/copyright.py: Do not forget to remind about MULTIPLE_COPYRIGHT_HEADERS

[Joel Brobecker]

There is a small logical error in the part of the script that
dumps the list of files in BY_HAND + MULTIPLE_COPYRIGHT_HEADERS
but only checkis the contents of BY_HAND. The issue becomes
apparent as soon as BY_HAND is empty. Prevent this from happening
by treating the two lists separately, as this allows us to provide
a more informative message in the case of MULTIPLE_COPYRIGHT_HEADERS.

gdb/ChangeLog:

        * copyright.py (main): Dump the contents of
        MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
        even if BY_HAND is empty.
---
 gdb/ChangeLog    |  6 ++++++
 gdb/copyright.py | 11 ++++++++++-
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 929c513a78..27f7c7ffee 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
 
+	* copyright.py (main): Dump the contents of
+	MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
+	even if BY_HAND is empty.
+
+2018-01-01  Joel Brobecker  <brobecker@adacore.com>
+
 	* top.c (print_gdb_version): Update Copyright year in version
 	message.
 
diff --git a/gdb/copyright.py b/gdb/copyright.py
index dca2d56f98..bb21b21601 100644
--- a/gdb/copyright.py
+++ b/gdb/copyright.py
@@ -150,11 +150,20 @@ def main ():
     update_files (update_list)
 
     # Remind the user that some files need to be updated by HAND...
+
+    if MULTIPLE_COPYRIGHT_HEADERS:
+        print
+        print("\033[31m"
+              "REMINDER: Multiple copyright headers must be updated by hand:"
+              "\033[0m")
+        for filename in MULTIPLE_COPYRIGHT_HEADERS:
+            print "  ", filename
+
     if BY_HAND:
         print
         print "\033[31mREMINDER: The following files must be updated by hand." \
               "\033[0m"
-        for filename in BY_HAND + MULTIPLE_COPYRIGHT_HEADERS:
+        for filename in BY_HAND:
             print "  ", filename
 
 ############################################################################
-- 
2.11.0

Re: GDB "Start of New Year Procedure" -- 2018 edition

[Joel Brobecker]

> I am about to push the following commits. Most of them are a direct
> application of the "Start of New Year Procedure" procedure listed
> in our GDB Internals Manual. A couple of them are tiny adjustments
> to the gdb/copyright.sh script to remove the need for a manual update
> of a couple of files that can now be processed automatically, and
> before that fix a small bug which is hidden until we remove those
> the special processing for those two files.
> 
>   * [PATCH 1/5] Yearly rotation of the gdb/ChangeLog file
>   * [PATCH 2/5] Update copyright year in version message of GDB,
>   * [PATCH 3/5] gdb/copyright.py: Do not forget to remind about
>   * [PATCH 4/5] gdb/copyright.py: Remove
>   * [PATCH 5/5] Update copyright year range in all GDB files

Patch #1 and patch #5 did not make it to the list, because the diff
itself was too big (no big surprise).

gdb/ChangeLog

        * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.

gdb/ChangeLog:

        Update copyright year range in all GDB files

The patches are mechanical or automated updates, and are trivial
to generate now that we use git, so I don't think it's worth
re-sending. But let me know if you'd like to have them archived
here -- I can try sending a compressed diff instead.

-- 
Joel

Re: GDB "Start of New Year Procedure" -- 2018 edition

[Sergio Durigan Junior]

On Sunday, December 31 2017, Joel Brobecker wrote:

> Hello,
>
> I am about to push the following commits. Most of them are a direct
> application of the "Start of New Year Procedure" procedure listed
> in our GDB Internals Manual. A couple of them are tiny adjustments
> to the gdb/copyright.sh script to remove the need for a manual update
> of a couple of files that can now be processed automatically, and
> before that fix a small bug which is hidden until we remove those
> the special processing for those two files.
>
>   * [PATCH 1/5] Yearly rotation of the gdb/ChangeLog file
>   * [PATCH 2/5] Update copyright year in version message of GDB,
>   * [PATCH 3/5] gdb/copyright.py: Do not forget to remind about
>   * [PATCH 4/5] gdb/copyright.py: Remove
>   * [PATCH 5/5] Update copyright year range in all GDB files
>
> Tested by rebuilding GDB from scratch on x86_64-linux.

Thanks for taking care of this, Joel.

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/