From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] regresssion(internal-error) printing subprogram argument
Date: Wed, 03 Jan 2018 04:33:00 -0000 [thread overview]
Message-ID: <20180103043345.n6blge377ybsdx6q@adacore.com> (raw)
In-Reply-To: <07a154ef-b6f5-ad86-1410-a73620de4b5b@redhat.com>
Hi Pedro,
> > Maybe what we need is to be a little less aggressive then and
> > add a new symbol_name_match_type::SEARCH_SYMBOL instead that takes as
> > input a non-user-input search symbol like symbol_name_match_type::LITERAL
> > was, and then we skip any decoding/demangling steps (like LITERAL) and make:
> > - Ada treat that as a verbatim match,
> > - other languages treat it as symbol_name_match_type::FULL.
[...]
> With the patch below applied on top, which is a minimal version of
> the design change I suggested (LITERAL -> SEARCH_SYMBOL), I now get
> again the same "maint check-psymtabs" output that I get with system gdb.
> So seems like this is on the good track.
>
> Your internal-error test still passes as well as the new
> "maint check-psymtabs" for gdb.ada/ testcase.
Sounds like we are indeed on the right track!
I ran the changes through both the official testsuite and AdaCore's
testsuite, and I can confirm no regression :). Is there something
else I can do to help?
--
Joel
next prev parent reply other threads:[~2018-01-03 4:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 10:37 Joel Brobecker
2017-12-14 19:02 ` Pedro Alves
2017-12-14 19:41 ` Pedro Alves
2017-12-15 9:48 ` Joel Brobecker
2017-12-15 11:02 ` Pedro Alves
2017-12-15 18:57 ` Pedro Alves
2018-01-03 4:33 ` Joel Brobecker [this message]
2018-01-04 9:48 ` Joel Brobecker
2018-01-04 12:39 ` Pedro Alves
2018-01-05 16:28 ` Pedro Alves
2018-01-16 11:54 ` Pedro Alves
2018-01-17 9:13 ` Joel Brobecker
2018-01-26 3:51 ` Joel Brobecker
2018-01-26 11:28 ` Pedro Alves
2018-01-29 10:38 ` Joel Brobecker
2018-01-29 15:33 ` Pedro Alves
2018-01-29 15:52 ` Joel Brobecker
2018-01-30 3:56 ` Joel Brobecker
2018-02-05 9:57 ` Joel Brobecker
2018-02-09 9:09 ` [RFA/RFC] fix PR gdb/22670 (pb looking up some symbols when they have a linkage name) (was: "Re: [RFC] regresssion(internal-error) printing subprogram argument") Joel Brobecker
2018-02-21 3:02 ` PING: " Joel Brobecker
2018-03-19 21:22 ` PING^2: " Joel Brobecker
2018-03-26 14:26 ` PING^2: [RFA/RFC] fix PR gdb/22670 (pb looking up some symbols when they have a linkage name) Pedro Alves
2018-03-27 14:02 ` Joel Brobecker
2018-01-26 4:50 ` [RFC] regresssion(internal-error) printing subprogram argument Joel Brobecker
2017-12-15 18:31 ` Pedro Alves
2017-12-15 7:54 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103043345.n6blge377ybsdx6q@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).