From: Joel Brobecker <brobecker@adacore.com>
To: Xavier Roirand <roirand@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/DWARF v2] Fix breakpoint add on inlined function using function name.
Date: Wed, 03 Jan 2018 04:44:00 -0000 [thread overview]
Message-ID: <20180103044418.d45mvob2b4o2vefp@adacore.com> (raw)
In-Reply-To: <1513776096-19313-1-git-send-email-roirand@adacore.com>
Hi Xavier,
> gdb/ChangeLog:
>
> * dwarf2read.c (scan_partial_symbols, add_partial_symbol)
> (add_partial_subprogram, load_partial_dies): Add
> DW_TAG_inlined_subroutine handling.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.ada/bp_inlined_func: New testcase.
The compiler is detecting a bug in your code:
> @@ -9412,7 +9415,7 @@ add_partial_subprogram (struct partial_die_info *pdi,
> CORE_ADDR *lowpc, CORE_ADDR *highpc,
> int set_addrmap, struct dwarf2_cu *cu)
> {
> - if (pdi->tag == DW_TAG_subprogram)
> + if (pdi->tag == DW_TAG_subprogram || DW_TAG_inlined_subroutine)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
It should be "|| pdi->tag == DW_TAG_inlined_subroutine".
Can you re-send a fixed version, please?
--
Joel
prev parent reply other threads:[~2018-01-03 4:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 13:23 Xavier Roirand
2017-12-21 2:35 ` Simon Marchi
2017-12-21 11:03 ` Joel Brobecker
2017-12-21 22:52 ` Simon Marchi
2017-12-22 2:59 ` Joel Brobecker
2018-01-03 4:44 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103044418.d45mvob2b4o2vefp@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=roirand@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).