From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95297 invoked by alias); 3 Jan 2018 04:44:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95275 invoked by uid 89); 3 Jan 2018 04:44:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Jan 2018 04:44:24 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1045511753D; Tue, 2 Jan 2018 23:44:23 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id KGTuLtDtd-qy; Tue, 2 Jan 2018 23:44:23 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A3EE711747A; Tue, 2 Jan 2018 23:44:22 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 7BFFF809B6; Wed, 3 Jan 2018 08:44:18 +0400 (+04) Date: Wed, 03 Jan 2018 04:44:00 -0000 From: Joel Brobecker To: Xavier Roirand Cc: gdb-patches@sourceware.org Subject: Re: [RFA/DWARF v2] Fix breakpoint add on inlined function using function name. Message-ID: <20180103044418.d45mvob2b4o2vefp@adacore.com> References: <1513776096-19313-1-git-send-email-roirand@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513776096-19313-1-git-send-email-roirand@adacore.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-01/txt/msg00025.txt.bz2 Hi Xavier, > gdb/ChangeLog: > > * dwarf2read.c (scan_partial_symbols, add_partial_symbol) > (add_partial_subprogram, load_partial_dies): Add > DW_TAG_inlined_subroutine handling. > > gdb/testsuite/ChangeLog: > > * gdb.ada/bp_inlined_func: New testcase. The compiler is detecting a bug in your code: > @@ -9412,7 +9415,7 @@ add_partial_subprogram (struct partial_die_info *pdi, > CORE_ADDR *lowpc, CORE_ADDR *highpc, > int set_addrmap, struct dwarf2_cu *cu) > { > - if (pdi->tag == DW_TAG_subprogram) > + if (pdi->tag == DW_TAG_subprogram || DW_TAG_inlined_subroutine) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ It should be "|| pdi->tag == DW_TAG_inlined_subroutine". Can you re-send a fixed version, please? -- Joel