From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87883 invoked by alias); 4 Jan 2018 01:50:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87869 invoked by uid 89); 4 Jan 2018 01:50:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=PATH_MAX, path_max X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Jan 2018 01:50:19 +0000 Received: from ralph.baldwin.cx.com (astound-66-234-202-155.ca.astound.net [66.234.202.155]) by mail.baldwin.cx (Postfix) with ESMTPSA id F1E7110A8C2 for ; Wed, 3 Jan 2018 20:50:17 -0500 (EST) From: John Baldwin To: gdb-patches@sourceware.org Subject: [PATCH v2 2/5] Don't return stale data from fbsd_pid_to_exec_file for kernel processes. Date: Thu, 04 Jan 2018 01:50:00 -0000 Message-Id: <20180104014923.11899-3-jhb@FreeBSD.org> In-Reply-To: <20180104014923.11899-1-jhb@FreeBSD.org> References: <20180104014923.11899-1-jhb@FreeBSD.org> X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00043.txt.bz2 For processes without an associated executable (such as kernel processes), the kern.proc.pathname. system control node returns a length of zero without modifying the user's buffer. Detect this case and return NULL rather than the previous contents of the static buffer 'buf'. gdb/ChangeLog: * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return NULL for an empty pathname. --- gdb/ChangeLog | 5 +++++ gdb/fbsd-nat.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 29cfbb287b..804dd4f402 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-01-03 John Baldwin + + * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return + NULL for an empty pathname. + 2018-01-03 John Baldwin * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET) diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c index ec4eed9abe..7b1d1bf148 100644 --- a/gdb/fbsd-nat.c +++ b/gdb/fbsd-nat.c @@ -63,7 +63,7 @@ fbsd_pid_to_exec_file (struct target_ops *self, int pid) mib[3] = pid; buflen = sizeof buf; if (sysctl (mib, 4, buf, &buflen, NULL, 0) == 0) - return buf; + return buflen == 0 ? NULL : buf; #endif xsnprintf (name, PATH_MAX, "/proc/%d/exe", pid); -- 2.15.1