From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2733 invoked by alias); 5 Jan 2018 03:22:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2705 invoked by uid 89); 5 Jan 2018 03:22:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=our X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 Jan 2018 03:22:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DFD721177E5; Thu, 4 Jan 2018 22:21:59 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Zp2jJLLXe3K5; Thu, 4 Jan 2018 22:21:59 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7DA1F1177E4; Thu, 4 Jan 2018 22:21:59 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 15ABB808EA; Fri, 5 Jan 2018 07:21:55 +0400 (+04) Date: Fri, 05 Jan 2018 03:22:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Add gdb.ada/info_addr_mixed_case new testcase Message-ID: <20180105032155.kn553rit4365f6bb@adacore.com> References: <1515054953-81012-1-git-send-email-brobecker@adacore.com> <1515054953-81012-2-git-send-email-brobecker@adacore.com> <5c1398c0-0b8a-f480-551c-d1c2c65daed8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-01/txt/msg00066.txt.bz2 > Turns out that the Ada symbol lookup machinery is sufficiently decoupled > from "regular" lookup that the problem is elsewhere. > While we may still want to consider migrating that hack towards > symbol_name_match_type::EXPRESSION, things should still work in > principle without doing that, AFAICT. > > Whether to do a full or wild match is decided based on the lookup name > string (see name_match_type_from_name). That was introduced basically > as a refactor of preexisting code, IIRC. > > I traced the problem to the verbatim-wrapping hack in > ada_lookup_encoded_symbol. > > See the attached patch. It fixes gdb.ada/info_addr_mixed_case, > and introduces no regressions for me. WDYT? Nice! > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > PR gdb/22670 > * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of > ada_lookup_symbol. > (ada_lookup_symbol): Reimplement in terms of > ada_lookup_symbol_list, bits factored out from > ada_lookup_encoded_symbol. > > gdb/testsuite/ChangeLog: > yyyy-mm-dd Pedro Alves > > PR gdb/22670 > * gdb.ada/info_addr_mixed_case.exp: Remove kfail. Extend test to > exercise lower case too, and to exercise both full matching and > wild matching. Patch looks good to me. Intuitively, it looks like a more logical way to perform things too. And with the new SEARCH_SYMBOL searching mechanism coming, I can see us being able later to to avoid the "<...>" wrapping too. Just in case, I tested that patch against our testsuite, and I can confirm it fixes the issue without introducing regressions :). Thanks for having looked into this, Pedro. I will focus my attention on creating the branch, do a review or two, and then continue analyzing my testsuite report. -- Joel