From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69223 invoked by alias); 8 Jan 2018 07:33:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69174 invoked by uid 89); 8 Jan 2018 07:33:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Jan 2018 07:33:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6A86411755E; Mon, 8 Jan 2018 02:33:49 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id yVHZjiOEF88A; Mon, 8 Jan 2018 02:33:49 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 04E87117503; Mon, 8 Jan 2018 02:33:49 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id AA2FE8304F; Mon, 8 Jan 2018 11:33:44 +0400 (+04) Date: Mon, 08 Jan 2018 07:33:00 -0000 From: Joel Brobecker To: Ruslan Kabatsayev Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Make tests expect [ \t]+ pattern instead of \t for "info reg" command Message-ID: <20180108073344.epy4aqmylu2f5ck7@adacore.com> References: <1515363510-18374-1-git-send-email-b7.10110111@gmail.com> <20180108042544.yzq3egkfph2c6v45@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-01/txt/msg00154.txt.bz2 > >> gdb/testsuite/ChangeLog: > >> > >> * gdb.arch/powerpc-d128-regs.exp: Replace expected "\[\t\]*" from > >> "info reg" with "\[ \t\]*". > >> * gdb.arch/altivec-regs.exp: Replace expected "\t" from "info reg" with > >> "\[ \t\]+". > >> * gdb.arch/s390-multiarch.exp: Ditto. > >> * gdb.base/pc-fp.exp: Ditto. > >> * gdb.reverse/i386-precsave.exp: Ditto. > >> * gdb.reverse/i386-reverse.exp: Ditto. > >> * gdb.reverse/i387-env-reverse.exp: Ditto. > >> * gdb.reverse/i387-stack-reverse.exp: Ditto. > > > > No objection on my end. I might have used \\s instead of \[ \t\], > > but perhaps there was a reason not to; and even if not, no point > > in redoing it all now. > > \\s would also allow newlines, form feeds etc., which doesn't look > like a good idea here. Hmmm, true. Forgot about newlines in particular. > >> - "pc +${valueof_pc}\t${valueof_pc} <.*>\[\r\n\]+fp +${valueof_fp}\t${valueof_fp}\[\r\n\]+" > >> + "pc +${valueof_pc}\[ \t\]+${valueof_pc} <.*>\[\r\n\]+fp +${valueof_fp}\[ \t\]+${valueof_fp}\[\r\n\]+" > > > > This change looks like it's doing more than just allowing spaces > > on top of tabs... > > Well it allows _multiple_ spaces/tabs instead of exactly one tab — > exactly what we need to be compatible with space-alignment. In other > respects I don't see what else it does. My mistake. I was seeing 2 new lines, because one of the '+' lined up exactly at the start of the next line when wraparound gets involved. Upon re-examination, the change looks fine indeed. -- Joel