From: Philipp Rudo <prudo@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Cc: Andreas Arnez <arnez@linux.vnet.ibm.com>,
Ulrich Weigand <uweigand@de.ibm.com>,
Yao Qi <qiyaoltc@gmail.com>
Subject: [PATCH v4 01/11] s390: Remove duplicate checks for cached gdbarch at init
Date: Tue, 09 Jan 2018 12:02:00 -0000 [thread overview]
Message-ID: <20180109120144.93854-2-prudo@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180109120144.93854-1-prudo@linux.vnet.ibm.com>
When initializing the gdbarch there is a check whether an appropriate
gdbarch already exists in the gdbarch_list. Failing of some of the checks
would lead to a different target description. However
gdbarch_list_lookup_by_info already checks for
if (info->target_desc != arches->gdbarch->target_desc)
continue;
Remove these duplicate checks.
gdb/ChangeLog:
* s390-linux-tdep.c (s390_gdbarch_init): Remove douplicate checks when
looking for cached gdbarch and add comment for remaining.
---
gdb/s390-linux-tdep.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/gdb/s390-linux-tdep.c b/gdb/s390-linux-tdep.c
index bdde5c34c8..5f4ed3a9af 100644
--- a/gdb/s390-linux-tdep.c
+++ b/gdb/s390-linux-tdep.c
@@ -8048,14 +8048,11 @@ s390_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
tdep = gdbarch_tdep (arches->gdbarch);
if (!tdep)
continue;
- if (tdep->abi != tdep_abi)
- continue;
+ /* A program can 'choose' not to use the vector registers when they
+ are present. Leading to the same tdesc but different tdep and
+ thereby a different gdbarch. */
if (tdep->vector_abi != vector_abi)
continue;
- if ((tdep->gpr_full_regnum != -1) != have_upper)
- continue;
- if (tdep->have_gs != have_gs)
- continue;
if (tdesc_data != NULL)
tdesc_data_cleanup (tdesc_data);
return arches->gdbarch;
--
2.13.5
next prev parent reply other threads:[~2018-01-09 12:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 12:01 [PATCH v4 00/11] Split up s390-linux-tdep.c Philipp Rudo
2018-01-09 12:01 ` [PATCH v4 03/11] s390: gdbarch_tdep.have_* int -> bool Philipp Rudo
2018-01-09 12:01 ` [PATCH v4 04/11] s390: gdbarch_tdep add field tdesc Philipp Rudo
2018-01-09 12:02 ` [PATCH v4 10/11] s390: Move record-replay to s390-tdep Philipp Rudo
2018-01-09 12:02 ` [PATCH v4 06/11] s390: if -> gdb_assert for tdesc_has_registers check Philipp Rudo
2018-01-09 12:02 ` [PATCH v4 09/11] s390: Split up s390-linux-tdep.c into two files Philipp Rudo
2018-01-09 12:02 ` Philipp Rudo [this message]
2018-01-09 12:02 ` [PATCH v4 08/11] s390: gdbarch_tdep add hook for syscall record Philipp Rudo
2018-01-09 12:02 ` [PATCH v4 07/11] s390: Hook s390 into OSABI mechanism Philipp Rudo
2018-01-09 12:02 ` [PATCH v4 05/11] s390: Move tdesc validation to separate function Philipp Rudo
2018-01-09 12:02 ` [PATCH v4 11/11] s390: Clean up s390-linux-tdep.c Philipp Rudo
2018-01-09 14:09 ` [PATCH v4 00/11] Split " Ulrich Weigand
2018-01-23 12:53 ` Andreas Arnez
2018-01-10 13:10 ` [PATCH v4 02/11] s390: Allocate gdbarch & tdep at start of gdbarch_init Philipp Rudo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109120144.93854-2-prudo@linux.vnet.ibm.com \
--to=prudo@linux.vnet.ibm.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).