public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Philipp Rudo <prudo@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Cc: Andreas Arnez <arnez@linux.vnet.ibm.com>,
	       Ulrich Weigand <uweigand@de.ibm.com>,
	Yao Qi <qiyaoltc@gmail.com>
Subject: [PATCH v4 08/11] s390: gdbarch_tdep add hook for syscall record
Date: Tue, 09 Jan 2018 12:02:00 -0000	[thread overview]
Message-ID: <20180109120144.93854-9-prudo@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180109120144.93854-1-prudo@linux.vnet.ibm.com>

Most parts of s390_process_record are common for the architecture.  Only
the systemcall handling differs between the OSes.  In order to be able to
move s390_process_record to a common code file add a hook to record
syscalls to gdbarch_tdep.  So every OS can implement their own handling.

gdb/ChangeLog:

	* s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
	(s390_process_record, s390_gdbarch_tdep_alloc)
	(s390_linux_init_abi_any): Use/Set new hook.
---
 gdb/s390-linux-tdep.c | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/gdb/s390-linux-tdep.c b/gdb/s390-linux-tdep.c
index b5837a4600..81f3e75417 100644
--- a/gdb/s390-linux-tdep.c
+++ b/gdb/s390-linux-tdep.c
@@ -122,6 +122,9 @@ struct gdbarch_tdep
   bool have_tdb;
   bool have_vx;
   bool have_gs;
+
+  /* Hook to record OS specific systemcall.  */
+  int (*s390_syscall_record) (struct regcache *regcache, LONGEST svc_number);
 };
 
 
@@ -3809,6 +3812,7 @@ static int
 s390_process_record (struct gdbarch *gdbarch, struct regcache *regcache,
                     CORE_ADDR addr)
 {
+  struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
   uint16_t insn[3] = {0};
   /* Instruction as bytes.  */
   uint8_t ibyte[6];
@@ -3965,8 +3969,16 @@ ex:
 
     case 0x0a:
       /* SVC - supervisor call */
-      if (s390_linux_syscall_record (regcache, ibyte[1]))
-        return -1;
+      if (tdep->s390_syscall_record != NULL)
+	{
+	  if (tdep->s390_syscall_record (regcache, ibyte[1]))
+	    return -1;
+	}
+      else
+	{
+	  printf_unfiltered (_("no syscall record support\n"));
+	  return -1;
+	}
       break;
 
     case 0x0b: /* BSM - branch and set mode */
@@ -7998,6 +8010,8 @@ s390_gdbarch_tdep_alloc ()
   tdep->have_vx = false;
   tdep->have_gs = false;
 
+  tdep->s390_syscall_record = NULL;
+
   return tdep;
 }
 
@@ -8196,6 +8210,10 @@ s390_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
 static void
 s390_linux_init_abi_any (struct gdbarch_info info, struct gdbarch *gdbarch)
 {
+  struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
+
+  tdep->s390_syscall_record = s390_linux_syscall_record;
+
   linux_init_abi (info, gdbarch);
 
   /* Register handling.  */
-- 
2.13.5

  parent reply	other threads:[~2018-01-09 12:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 12:01 [PATCH v4 00/11] Split up s390-linux-tdep.c Philipp Rudo
2018-01-09 12:01 ` [PATCH v4 03/11] s390: gdbarch_tdep.have_* int -> bool Philipp Rudo
2018-01-09 12:01 ` [PATCH v4 04/11] s390: gdbarch_tdep add field tdesc Philipp Rudo
2018-01-09 12:02 ` [PATCH v4 10/11] s390: Move record-replay to s390-tdep Philipp Rudo
2018-01-09 12:02 ` [PATCH v4 06/11] s390: if -> gdb_assert for tdesc_has_registers check Philipp Rudo
2018-01-09 12:02 ` [PATCH v4 09/11] s390: Split up s390-linux-tdep.c into two files Philipp Rudo
2018-01-09 12:02 ` Philipp Rudo [this message]
2018-01-09 12:02 ` [PATCH v4 01/11] s390: Remove duplicate checks for cached gdbarch at init Philipp Rudo
2018-01-09 12:02 ` [PATCH v4 07/11] s390: Hook s390 into OSABI mechanism Philipp Rudo
2018-01-09 12:02 ` [PATCH v4 05/11] s390: Move tdesc validation to separate function Philipp Rudo
2018-01-09 12:02 ` [PATCH v4 11/11] s390: Clean up s390-linux-tdep.c Philipp Rudo
2018-01-09 14:09 ` [PATCH v4 00/11] Split " Ulrich Weigand
2018-01-23 12:53   ` Andreas Arnez
2018-01-10 13:10 ` [PATCH v4 02/11] s390: Allocate gdbarch & tdep at start of gdbarch_init Philipp Rudo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109120144.93854-9-prudo@linux.vnet.ibm.com \
    --to=prudo@linux.vnet.ibm.com \
    --cc=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).