From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72775 invoked by alias); 30 Jan 2018 04:57:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72763 invoked by uid 89); 30 Jan 2018 04:57:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Jan 2018 04:57:57 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0C4C3560A5; Mon, 29 Jan 2018 23:57:56 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6HRwnUvIjvbD; Mon, 29 Jan 2018 23:57:55 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9EBA05601D; Mon, 29 Jan 2018 23:57:55 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id E82D983307; Tue, 30 Jan 2018 08:57:50 +0400 (+04) Date: Tue, 30 Jan 2018 04:57:00 -0000 From: Joel Brobecker To: Xavier Roirand Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] (Ada) C++fy conditional string when catching exception. Message-ID: <20180130045750.yh7rgqz3sz3gd2nd@adacore.com> References: <20180123114306.b6w2csxzygomqlnd@adacore.com> <1517230019-30061-1-git-send-email-roirand@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1517230019-30061-1-git-send-email-roirand@adacore.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-01/txt/msg00618.txt.bz2 On Mon, Jan 29, 2018 at 01:46:59PM +0100, Xavier Roirand wrote: > This commit C++fy the conditional string used when catching Ada exception. > > gdb/ChangeLog: > > * ada-lang.c (catch_ada_exception_command_split) > (create_ada_exception_catchpoint) : Change parameter > type. Update code accordingly. > (catch_ada_exception_command, catch_ada_handlers_command): Use > C++ string instead of char* for conditional var. > (catch_ada_assert_command_split) : Change parameter > type. Update code accordingly. > (catch_assert_command): Use C++ string instead of char* for > conditional var. > * ada-lang.h (create_ada_exception_catchpoint) : > Update declaration. > * mi/mi-cmd-catch.c (mi_cmd_catch_assert, mi_cmd_catch_exception: Missing closing ')'. > Use std::string instead of char* for condition string. Looks good to me. Well done! -- Joel