From: Bartosz Nitka <niteria@gmail.com>
To: gdb-patches@sourceware.org
Cc: Bartosz Nitka <niteria@gmail.com>
Subject: [PATCH v3 0/1] Don't rewind PC for GHC generated frames
Date: Sun, 04 Feb 2018 00:07:00 -0000 [thread overview]
Message-ID: <20180204000647.19188-1-niteria@gmail.com> (raw)
Hi Simon and everyone else,
Thank you Simon for taking a look at my patch.
The only thing that changed between v2 and v3 is the
commit log.
The main improvement is an example that shows the impact
of this change. The example is fairly small, on bigger ones the
effect is bigger. I've been using GDB for debugging Haskell
code and often you have to resort to manually unwinding the
stack, which can be time consuming and isn't friendly to beginners.
I've also corrected the claim that substracting 1 would
somehow land us at the beginning of the call instruction
and reworded a couple of sentences to make it read better.
As a side note, Haskell code can be pretty dense and a lot
of functionality can fit on one line. GHC already puts column
numbers in the debugging information, but from what I can tell
GDB doesn't expose that in any way.
Would that be a worthwhile addition to GDB?
Thanks,
Bartosz
Bartosz Nitka (1):
Don't rewind PC for GHC generated frames
gdb/ChangeLog | 7 +++++++
gdb/dwarf2read.c | 4 ++++
gdb/frame.c | 9 ++++++++-
gdb/symtab.h | 3 +++
4 files changed, 22 insertions(+), 1 deletion(-)
--
2.14.1
next reply other threads:[~2018-02-04 0:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-04 0:07 Bartosz Nitka [this message]
2018-02-04 0:07 ` [PATCH v3 1/1] " Bartosz Nitka
2018-02-12 12:35 ` Bartosz Nitka
2018-02-12 15:44 ` Simon Marchi
2018-02-19 13:10 ` Bartosz Nitka
2018-02-19 17:02 ` Simon Marchi
2018-02-12 13:50 ` [PATCH v3 0/1] " Yao Qi
2018-02-12 14:14 ` Bartosz Nitka
2018-02-12 14:42 ` Yao Qi
2018-02-19 13:27 ` Bartosz Nitka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180204000647.19188-1-niteria@gmail.com \
--to=niteria@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).