From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124759 invoked by alias); 22 Feb 2018 03:38:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124749 invoked by uid 89); 22 Feb 2018 03:38:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=eyes X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Feb 2018 03:38:33 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 01144116378; Wed, 21 Feb 2018 22:38:32 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qItj3yZsLF3r; Wed, 21 Feb 2018 22:38:31 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8F8E81162D2; Wed, 21 Feb 2018 22:38:31 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 0A57783054; Thu, 22 Feb 2018 07:38:27 +0400 (+04) Date: Thu, 22 Feb 2018 03:38:00 -0000 From: Joel Brobecker To: Yao Qi Cc: Xavier Roirand , GDB Patches Subject: Re: [RFA] Fix frame argument printing when using auto language mode Message-ID: <20180222033826.scpiuiper3lhdbtm@adacore.com> References: <1519044767-8741-1-git-send-email-roirand@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-02/txt/msg00304.txt.bz2 Hi Yao, > We don't have to do that. ada_val_print_1 is called in ada_val_print, > > ada_val_print_1 (type, embedded_offset, address, > stream, recurse, val, options, > current_language); > > and ada_val_print is language->la_val_print in effect, so "language" > is ada_language_defn, and we can rewrite the code above like this, > > ada_val_print_1 (type, embedded_offset, address, > stream, recurse, val, options, > &ada_language_defn); > > This change may break existing behaviour. Printing for ada (or other > languages) shouldn't depend on current_language, IMO. Thanks for the extra pair of eyes, and the pertinent suggestions! FWIW, I agree with you, your fix is much better. -- Joel