public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* Re: FYI - RFC about making GMP a required dep for GDB
       [not found] <20180311153253.bbvitoukomciwtjh@adacore.com>
@ 2018-03-11 17:15 ` Eli Zaretskii
  2018-03-11 20:00   ` Joel Brobecker
  0 siblings, 1 reply; 2+ messages in thread
From: Eli Zaretskii @ 2018-03-11 17:15 UTC (permalink / raw)
  To: Joel Brobecker; +Cc: gdb-patches

> Date: Sun, 11 Mar 2018 11:32:53 -0400
> From: Joel Brobecker <brobecker@adacore.com>
> 
> Hi Eli,
> 
> I just wanted to make sure you saw the following proposal, in case
> you wanted to provide feedback about it. No worries if you don't!

I missed that somehow, or maybe didn't think my input was important.
Thanks for the heads up.

> But if you do, could you send it on the list?  So far, I got one answer,
> which was positive.
> 
> https://www.sourceware.org/ml/gdb-patches/2018-03/msg00148.html

I have no problems with adding this dependency.  A GDB built with MPFR
already indirectly depends on GMP as well, so it sounds like that ship
has sailed already.  MinGW ports of GMP are available, so portability
to native MS-Windows should not be an issue.

(Btw, would it make sense to provide the features via MPFR?  Than we'd
have only one explicit dependency.  Not that it matters too much.)

HTH

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: FYI - RFC about making GMP a required dep for GDB
  2018-03-11 17:15 ` FYI - RFC about making GMP a required dep for GDB Eli Zaretskii
@ 2018-03-11 20:00   ` Joel Brobecker
  0 siblings, 0 replies; 2+ messages in thread
From: Joel Brobecker @ 2018-03-11 20:00 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: gdb-patches

> I have no problems with adding this dependency.  A GDB built with MPFR
> already indirectly depends on GMP as well, so it sounds like that ship
> has sailed already.  MinGW ports of GMP are available, so portability
> to native MS-Windows should not be an issue.

Excellent news! :)

> (Btw, would it make sense to provide the features via MPFR?  Than we'd
> have only one explicit dependency.  Not that it matters too much.)

Unless I'm mistaken, the dependency on MPFR is currently optional.
I think Ulrich was able to do that by limiting as much as possible
the operations he wanted to perform, and by abstracting those out.
The abstraction layer kind of makes sense for floats, because there
is always going to be at least 2 kinds of floating points (binary
floating points, and decimal floating points, which are handled by
two different libraries). For GMP, it makes less sense, IMO.

That being said - I think the code would be slightly less complex
if we made both GMP and MPFR required, and this would ensure that
users always get the MPFR-capable version, which gives more accurate
results.

-- 
Joel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-03-11 20:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20180311153253.bbvitoukomciwtjh@adacore.com>
2018-03-11 17:15 ` FYI - RFC about making GMP a required dep for GDB Eli Zaretskii
2018-03-11 20:00   ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).