From: Keith Seitz <keiths@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] Remove struct keyword from section_addr_info
Date: Fri, 23 Mar 2018 20:36:00 -0000 [thread overview]
Message-ID: <20180323203608.8939-1-keiths@redhat.com> (raw)
Buildbot pointed out a failiure in windows-nat.c:
../../binutils-gdb/gdb/windows-nat.c:582:10: error: using typedef-name 'section_addr_info' after 'struct'
struct section_addr_info *addrs;
^~~~~~~~~~~~~~~~~
In file included from ../../binutils-gdb/gdb/windows-nat.c:49:0:
../../binutils-gdb/gdb/symfile.h:75:37: note: 'section_addr_info' has a previous declaration here
typedef std::vector<other_sections> section_addr_info;
^~~~~~~~~~~~~~~~~
A recursive grep of the sources for "struct section_addr_info" reveals one
additional reference in a comment. In both cases, this patch simply removes
the struct keyword.
gdb/ChangeLog:
* symfile.c (place_section): Remove "struct" from section_addr_info
in comment.
* windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Likewise.
---
gdb/ChangeLog | 6 ++++++
gdb/symfile.c | 2 +-
gdb/windows-nat.c | 2 +-
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b543904db2..70d182d624 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2018-MM-DD Keith Seitz <keiths@redhat.com>
+
+ * symfile.c (place_section): Remove "struct" from section_addr_info
+ in comment.
+ * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Likewise.
+
2018-03-23 Keith Seitz <keiths@redhat.com>
PR c++/22968
diff --git a/gdb/symfile.c b/gdb/symfile.c
index 9571664776..1e5297ee29 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -412,7 +412,7 @@ place_section (bfd *abfd, asection *sect, void *obj)
arg->lowest = start_addr + bfd_get_section_size (sect);
}
-/* Store struct section_addr_info as prepared (made relative and with SECTINDEX
+/* Store section_addr_info as prepared (made relative and with SECTINDEX
filled-in) by addr_info_make_relative into SECTION_OFFSETS of NUM_SECTIONS
entries. */
diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index f849f1f322..430cc60993 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -579,7 +579,7 @@ struct safe_symbol_file_add_args
{
char *name;
int from_tty;
- struct section_addr_info *addrs;
+ section_addr_info *addrs;
int mainline;
int flags;
struct ui_file *err, *out;
--
2.13.6
next reply other threads:[~2018-03-23 20:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 20:36 Keith Seitz [this message]
2018-03-24 2:46 ` Simon Marchi
2018-03-26 17:39 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323203608.8939-1-keiths@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).