From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115425 invoked by alias); 27 Mar 2018 14:02:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115063 invoked by uid 89); 27 Mar 2018 14:02:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=our, wish X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Mar 2018 14:02:24 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2CB521167D9; Tue, 27 Mar 2018 10:02:23 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rCDi0pI3Th3e; Tue, 27 Mar 2018 10:02:23 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EEFAC116510; Tue, 27 Mar 2018 10:02:22 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1C8F68330A; Tue, 27 Mar 2018 07:02:21 -0700 (PDT) Date: Tue, 27 Mar 2018 14:02:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: PING^2: [RFA/RFC] fix PR gdb/22670 (pb looking up some symbols when they have a linkage name) Message-ID: <20180327140221.kisd66avp4slhnxp@adacore.com> References: <20180126035055.vbjtowj6q5ftbwiz@adacore.com> <21bfbb6a-bb10-812b-c34a-d367321e8d5e@redhat.com> <20180129103841.kdkomcjbuwiat5b4@adacore.com> <250976c6-6e7a-6a8e-b9f2-a57f5b92b965@redhat.com> <20180130035612.xghiskhiweftijxi@adacore.com> <20180205095659.y5jzjj2e5bx6pjyf@adacore.com> <20180209090919.lmwjll72hccopjsk@adacore.com> <20180221030210.xzthyal2cysn5s72@adacore.com> <20180319212158.narawyklbdhitd6i@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-03/txt/msg00557.txt.bz2 > >>> I ended up choosing this approach. lookup names is still a bit > >>> foggy for me, so the comments I wrote and/or the name of the > >>> new language_defn attribute might be a bit off. As always, I am > >>> grateful for suggestions :). > > I looked again at this today, and I couldn't think of a better > option right now. So I think you should go ahead and push this in. Thanks, Pedro. I re-tested the patch on x86_64-linux, and then pushed it to master. > Note that this C++ mangled form like in "symada__cS", is not > actually how C++ symbols are mangled nowadays. The modern Itanium > mangling scheme has linkage names that always start with "_Z". In this > case, "void symada(char, signed)" mangles as "_Z6symadaci". Interesting. > It's possible that we no longer need to support that older (and > ambiguous with Ada and other languages) mangling scheme for C++, I > don't know. I wish Ada linkage names also had some kind of leading > prefix, but that can't happen without an ABI break, of course... Yeah, it's a good idea, but making that kind of change happen is going to be tough, especially since we know there are consumers of our debugging information that we have no control of. I'll mention it to the compiler team, though. Thanks Pedro. -- Joel