From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 2/2] Set TYPE_NAME for Rust unions
Date: Fri, 13 Apr 2018 07:41:00 -0000 [thread overview]
Message-ID: <20180413074052.lxdfiypb3kq6ulp3@adacore.com> (raw)
In-Reply-To: <20180412190756.16052-3-tom@tromey.com>
> I think that TYPE_TAG_NAME is confusing and should probably be
> removed. I am working on a patch to do this, but in the meantime this
> seemed like a reasonable change to apply. I suspect this change would
> be ok for C++ as well, but I do not know about D.
I agree that TYPE_TAG_NAME is confusing, and I would welcome it being
removed.
> 2018-04-12 Tom Tromey <tom@tromey.com>
>
> * dwarf2read.c (read_structure_type): Set TYPE_NAME for rust
> unions.
The patch looks good to me, but I'd like to see if others have comments
about C++. I'm trying to remember if C++ enums might have different
rules compared to C enums, and I'm not remembering any... If there
weren't any difference, and things were OK with C enums, one might
think that we're OK for C++ enums as well...
No way to test this either?
--
Joel
next prev parent reply other threads:[~2018-04-13 7:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 19:08 [RFA 0/2] Minor Rust-related DWARF reader fixes Tom Tromey
2018-04-12 19:08 ` [RFA 1/2] Conditionally drop the discriminant field in quirk_rust_enum Tom Tromey
2018-04-13 7:36 ` Joel Brobecker
2018-04-12 19:12 ` [RFA 2/2] Set TYPE_NAME for Rust unions Tom Tromey
2018-04-13 7:41 ` Joel Brobecker [this message]
2018-04-17 19:37 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413074052.lxdfiypb3kq6ulp3@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).