From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83726 invoked by alias); 21 Apr 2018 18:31:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83681 invoked by uid 89); 21 Apr 2018 18:31:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=straightforward, buildbot X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.253) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 21 Apr 2018 18:31:01 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 5591D343ACF for ; Sat, 21 Apr 2018 13:30:59 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9xHnf84yxWCOC9xHnf3JRv; Sat, 21 Apr 2018 13:30:59 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:50954 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1f9xHn-002rFx-3E for gdb-patches@sourceware.org; Sat, 21 Apr 2018 13:30:59 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [RFA 0/9] Enable -Wimplicit-fallthrough Date: Sat, 21 Apr 2018 18:31:00 -0000 Message-Id: <20180421183056.29292-1-tom@tromey.com> X-BWhitelist: no X-Source-L: No X-Exim-ID: 1f9xHn-002rFx-3E X-Source-Sender: 97-122-176-117.hlrn.qwest.net (bapiya.Home) [97.122.176.117]:50954 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-04/txt/msg00424.txt.bz2 This series enables -Wimplicit-fallthrough for gdb. I think this is valuable because it can prevent the occasional bug. A couple of the patches are straightforward. For example, patch #1 changes existing "fall-through" comments to the correct form that will be recognized by GCC. In some cases I was not sure which change to make. I've split all these out in this series for easier review. Please examine them carefully. This applies to patches 4, 5, 6, and 8. I chose to use comments rather than the new fall-through attribute because the comments are more portable: they can be ignored by compilers that do not understand them, and they do not require additional configury. Tested by the buildbot. Tom