From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [RFA 2/9] Add missing ATTRIBUTE_NORETURNs
Date: Sat, 21 Apr 2018 18:31:00 -0000 [thread overview]
Message-ID: <20180421183056.29292-3-tom@tromey.com> (raw)
In-Reply-To: <20180421183056.29292-1-tom@tromey.com>
This patch adds a missing ATTRIBUTE_NORETURN. This lets
-Wimplicit-fallthrough recognize that a given case does not fall
through.
ChangeLog
2018-04-21 Tom Tromey <tom@tromey.com>
* dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
---
gdb/ChangeLog | 4 ++++
gdb/dwarf2loc.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c
index 6c84e4ad7e..f7eff7d6a5 100644
--- a/gdb/dwarf2loc.c
+++ b/gdb/dwarf2loc.c
@@ -2865,7 +2865,7 @@ dwarf2_loc_desc_get_symbol_read_needs (const gdb_byte *data, size_t size,
/* A helper function that throws an unimplemented error mentioning a
given DWARF operator. */
-static void
+static void ATTRIBUTE_NORETURN
unimplemented (unsigned int op)
{
const char *name = get_DW_OP_name (op);
--
2.13.6
next prev parent reply other threads:[~2018-04-21 18:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-21 18:31 [RFA 0/9] Enable -Wimplicit-fallthrough Tom Tromey
2018-04-21 18:31 ` [RFA 6/9] Add two fall-through comments in rs6000-tdep.c Tom Tromey
2018-04-21 18:31 ` [RFA 8/9] Add a missing break in record_linux_system_call Tom Tromey
2018-04-21 18:31 ` [RFA 4/9] Add a fall-through comment to stabsread.c Tom Tromey
2018-04-21 18:31 ` [RFA 3/9] Fix "obvious" fall-through warnings Tom Tromey
2018-04-21 18:31 ` [RFA 9/9] Add -Wimplicit-fallthrough Tom Tromey
2018-05-04 18:34 ` Pedro Alves
2018-05-04 18:47 ` Tom Tromey
2018-04-21 18:31 ` Tom Tromey [this message]
2018-04-21 18:31 ` [RFA 1/9] Fix "fall through" comments Tom Tromey
2018-04-21 18:31 ` [RFA 7/9] Add missing "breaks" Tom Tromey
2018-04-21 18:31 ` [RFA 5/9] Add fall-through comment to i386-tdep.c Tom Tromey
2018-04-24 20:37 ` John Baldwin
2018-05-04 17:51 ` [RFA 0/9] Enable -Wimplicit-fallthrough Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180421183056.29292-3-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).