From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [RFA 6/9] Add two fall-through comments in rs6000-tdep.c
Date: Sat, 21 Apr 2018 18:31:00 -0000 [thread overview]
Message-ID: <20180421183056.29292-7-tom@tromey.com> (raw)
In-Reply-To: <20180421183056.29292-1-tom@tromey.com>
This adds two fall-through comments in rs6000-tdep.c. I looked at the
PPC instruction manual and convinced myself that this was correct.
And, this isn't a semantic change. However, close review would still
be good.
ChangeLog
2018-04-21 Tom Tromey <tom@tromey.com>
* rs6000-tdep.c (ppc_process_record_op4)
(ppc_process_record_op63): Add fall-through comment.
---
gdb/ChangeLog | 5 +++++
gdb/rs6000-tdep.c | 2 ++
2 files changed, 7 insertions(+)
diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
index 37cbcb672b..2f0012479b 100644
--- a/gdb/rs6000-tdep.c
+++ b/gdb/rs6000-tdep.c
@@ -3969,6 +3969,7 @@ ppc_process_record_op4 (struct gdbarch *gdbarch, struct regcache *regcache,
&& vra != 7 /* Decimal Convert From National */
&& vra != 31) /* Decimal Set Sign */
break;
+ /* Fall through. */
/* 5.16 Decimal Integer Arithmetic Instructions */
case 1: /* Decimal Add Modulo */
case 65: /* Decimal Subtract Modulo */
@@ -5565,6 +5566,7 @@ ppc_process_record_op63 (struct gdbarch *gdbarch, struct regcache *regcache,
case 22: /* Move From FPSCR Control & set RN */
case 23: /* Move From FPSCR Control & set RN Immediate */
record_full_arch_list_add_reg (regcache, tdep->ppc_fpscr_regnum);
+ /* Fall through. */
case 0: /* Move From FPSCR */
case 24: /* Move From FPSCR Lightweight */
if (PPC_FIELD (insn, 11, 5) == 0 && PPC_RC (insn))
--
2.13.6
next prev parent reply other threads:[~2018-04-21 18:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-21 18:31 [RFA 0/9] Enable -Wimplicit-fallthrough Tom Tromey
2018-04-21 18:31 ` [RFA 5/9] Add fall-through comment to i386-tdep.c Tom Tromey
2018-04-24 20:37 ` John Baldwin
2018-04-21 18:31 ` [RFA 7/9] Add missing "breaks" Tom Tromey
2018-04-21 18:31 ` [RFA 1/9] Fix "fall through" comments Tom Tromey
2018-04-21 18:31 ` [RFA 2/9] Add missing ATTRIBUTE_NORETURNs Tom Tromey
2018-04-21 18:31 ` [RFA 9/9] Add -Wimplicit-fallthrough Tom Tromey
2018-05-04 18:34 ` Pedro Alves
2018-05-04 18:47 ` Tom Tromey
2018-04-21 18:31 ` [RFA 8/9] Add a missing break in record_linux_system_call Tom Tromey
2018-04-21 18:31 ` [RFA 4/9] Add a fall-through comment to stabsread.c Tom Tromey
2018-04-21 18:31 ` [RFA 3/9] Fix "obvious" fall-through warnings Tom Tromey
2018-04-21 18:31 ` Tom Tromey [this message]
2018-05-04 17:51 ` [RFA 0/9] Enable -Wimplicit-fallthrough Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180421183056.29292-7-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).