From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3281 invoked by alias); 3 May 2018 17:37:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3269 invoked by uid 89); 3 May 2018 17:37:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=focused X-HELO: mail-wm0-f45.google.com Received: from mail-wm0-f45.google.com (HELO mail-wm0-f45.google.com) (74.125.82.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 May 2018 17:37:16 +0000 Received: by mail-wm0-f45.google.com with SMTP id f6so246339wmc.4 for ; Thu, 03 May 2018 10:37:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=u8bzufleDYrM/MD+qLHzsUBmAfmXIlGq7xz/mqdcjpY=; b=PwPzbqvM3SzuQpHh8HaeC6FQgyxuiAw3dD5/+CRsygv5kwcuYN+pfIDLWtsnh/EimU W93BJsBPRvbPxayjXSAxAoLHNELtwl0TNkQmD3UY2m1OBdc5DcDh3QbPeDM+xDtx7RRF alCUSotD5NsjojIncaiXbDkPez3wDgy5klLnMXwGYvI+kIfiTCqt2Zd48Bh6TzXKbDOs 6Xgpq0kXD3pz/2/0Hu0zT+DAy5xzhgfjHq/WYwtwIcO5ovUUi6SxNG8zGVC4ca58QYB4 DiZuDvCzvAedG5zU55grTEfTua3tHzJ44PDoXovYOISIIAZcFDVSLWSR7Za+mmrmAbqf gniQ== X-Gm-Message-State: ALQs6tBfLbvQcZmvEnUaIcD/O7fdLu04wcBw7LjqPT/UrCp+2ygjY+su C7OQhsiemgs2kHae8M3NU5h6A9DP X-Google-Smtp-Source: AB8JxZqT+SpgDT7vs1VyDdztOp4KXyGPkZ8S0wq3oatj01EQyhfTPKQVMjP9RnKoOmhq6w4FMoXC9Q== X-Received: by 10.28.91.2 with SMTP id p2mr1978699wmb.20.1525369034270; Thu, 03 May 2018 10:37:14 -0700 (PDT) Received: from localhost (host81-147-175-127.range81-147.btcentralplus.com. [81.147.175.127]) by smtp.gmail.com with ESMTPSA id e50-v6sm37341350wre.4.2018.05.03.10.37.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 May 2018 10:37:13 -0700 (PDT) Date: Thu, 03 May 2018 17:37:00 -0000 From: Andrew Burgess To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2] gdb/x86: Handle kernels using compact xsave format Message-ID: <20180503173712.GI3375@embecosm.com> References: <20180503170624.20847-1-andrew.burgess@embecosm.com> <6131c1b9-21c1-6a38-f466-34bfef144a26@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6131c1b9-21c1-6a38-f466-34bfef144a26@redhat.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00054.txt.bz2 * Pedro Alves [2018-05-03 18:11:15 +0100]: > On 05/03/2018 06:06 PM, Andrew Burgess wrote: > > This patch is a follow-up for this patch: > > > > https://sourceware.org/ml/gdb-patches/2018-03/msg00275.html > > Can you summarize what changed in this version? Of course, sorry, I should have thought to do that. The original patch focused entirely on the fctrl register, which is where I saw the original problem. When I revisited the patch I realised that there's nothing special about that register, it was _all_ of the x87 control registers, that are broken (and mxcsr). So the biggest change is that after this patch _no_ registers are read from the xsave buffer unless the relevant feature is enabled. And _no_ register will be written back to the xsave buffer unless the value has been modified. I did manage to remove a '{ .... }' nesting level in this patch which means I've updated the indentation on a bunch of code. The patch also covers gdbserver, which the original patch didn't. Hope that helps, Thanks, Andrew