From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Pedro Alves <palves@redhat.com>, Yao Qi <qiyaoltc@gmail.com>,
gdb-patches@sourceware.org
Subject: [obv] watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests [Re: [patch] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones]
Date: Tue, 08 May 2018 12:27:00 -0000 [thread overview]
Message-ID: <20180508122730.GA177617@host1.jankratochvil.net> (raw)
In-Reply-To: <20180508120811.25BF1D804F5@oc3748833570.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
On Tue, 08 May 2018 14:08:11 +0200, Ulrich Weigand wrote:
> Jan Kratochvil wrote:
>
> > PR breakpoints/19806 and support for PR external/20207.
> > * gdb.base/watchpoint-unaligned.c: New file.
> > * gdb.base/watchpoint-unaligned.exp: New file.
>
> These new tests all fail on SPU. It looks like the test requires
> hardware watchpoints, should it check for [skip_hw_watchpoint_tests] ?
I was not aware of skip_hw_watchpoint_tests, checked in as obvious.
Thanks,
Jan
[-- Attachment #2: Type: message/rfc822, Size: 1359 bytes --]
From: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: [PATCH] watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests
Date: Tue, 8 May 2018 14:26:19 +0200
gdb/testsuite/ChangeLog
2018-05-08 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.base/watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests.
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.base/watchpoint-unaligned.exp | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 761fb7334c..d6db46916e 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2018-05-08 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * gdb.base/watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests.
+
2018-05-04 Tom Tromey <tom@tromey.com>
PR python/22730:
diff --git a/gdb/testsuite/gdb.base/watchpoint-unaligned.exp b/gdb/testsuite/gdb.base/watchpoint-unaligned.exp
index 6bdd4b6d05..66358f2747 100644
--- a/gdb/testsuite/gdb.base/watchpoint-unaligned.exp
+++ b/gdb/testsuite/gdb.base/watchpoint-unaligned.exp
@@ -17,6 +17,10 @@
# Test inserting read watchpoints on unaligned addresses.
+if {[skip_hw_watchpoint_tests]} {
+ return 0
+}
+
standard_testfile
if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile}] } {
return -1
--
2.14.3
next prev parent reply other threads:[~2018-05-08 12:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 21:08 [patch] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones Jan Kratochvil
2017-06-19 13:43 ` ping: " Jan Kratochvil
2017-06-19 13:44 ` Jan Kratochvil
2017-10-18 19:52 ` ping#2: " Jan Kratochvil
2017-10-30 11:27 ` Yao Qi
2017-11-03 22:04 ` Jan Kratochvil
2018-03-21 19:03 ` ping: " Jan Kratochvil
2018-04-20 14:49 ` Pedro Alves
2018-04-20 14:56 ` Pedro Alves
2018-04-20 15:54 ` Eli Zaretskii
2018-04-20 15:59 ` Pedro Alves
2018-04-26 20:12 ` Jan Kratochvil
2018-05-01 23:03 ` Jan Kratochvil
2018-05-01 23:06 ` Jan Kratochvil
2018-05-02 14:50 ` Eli Zaretskii
2018-05-03 9:16 ` Jan Kratochvil
2018-05-03 9:18 ` Jan Kratochvil
2018-05-04 16:40 ` Pedro Alves
2018-05-04 20:30 ` [commit] " Jan Kratochvil
2018-05-04 20:47 ` Pedro Alves
2018-05-07 8:03 ` Omair Javaid
2018-05-07 8:36 ` Jan Kratochvil
2018-05-08 12:08 ` [patch] " Ulrich Weigand
2018-05-08 12:27 ` Jan Kratochvil [this message]
2018-05-08 12:45 ` [obv] watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests [Re: [patch] aarch64: PR 19806: watchpoints: false negatives + PR Ulrich Weigand
2017-10-30 11:31 ` ping#2: [patch] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508122730.GA177617@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=qiyaoltc@gmail.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).