public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* cherry picking documentation patches to 8.1 branch
@ 2018-05-09 16:01 Szabolcs Nagy
  2018-05-09 17:33 ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Szabolcs Nagy @ 2018-05-09 16:01 UTC (permalink / raw)
  To: gdb-patches; +Cc: nd, Eli Zaretskii, Joel Brobecker

hello, i'd like to backport these patches into the 8.1 branch:

https://sourceware.org/ml/gdb-patches/2018-01/msg00259.html
https://sourceware.org/ml/gdb-patches/2018-01/msg00266.html

commit dbfa452355153093d4d6841515f9891c9572113f
Author:     Szabolcs Nagy <szabolcs.nagy@arm.com>
AuthorDate: 2018-01-15 10:44:12 +0000
Commit:     Szabolcs Nagy <szabolcs.nagy@arm.com>
CommitDate: 2018-01-15 11:43:33 +0000

     Fix gdb.texinfo for old makeinfo (again)

     With old makeinfo (version 4.13) the changes introduced in

     commit ba643918cf869fa0d064d733f69b453b6fe642ea
     Author:     Sergio Durigan Junior <sergiodj@redhat.com>

         Install and generate docs for gdb-add-index

     fail to build with

     gdb/doc/gdb.texinfo:2498: warning: `.' or `,' must follow @xref, not `@'.
     gdb/doc/gdb.texinfo:2517: warning: `.' or `,' must follow @xref, not `@'.
     gdb/doc/gdb.texinfo:43443: Node `gdb-add-index man' requires a sectioning command (e.g., @unnumberedsubsec).
     gdb/doc/gdb.texinfo:43443: `gdb-add-index man' has no Up field (perhaps incorrect sectioning?).
     gdb/doc/gdb.texinfo:43350: Next field of node `gdbinit man' not pointed to (perhaps incorrect sectioning?).
     gdb/doc/gdb.texinfo:43443: This node (gdb-add-index man) has the bad Prev.

     This patch fixes the warnings too.

     gdb/doc/ChangeLog:

             * gdb.texinfo (set cwd): Add period.
             (gdb-add-index man): Move anchor.


and

commit d726cb5d3784f7ed96318a2214ea777a86f9faad
Author:     Szabolcs Nagy <szabolcs.nagy@arm.com>
AuthorDate: 2018-01-15 13:06:45 +0000
Commit:     Szabolcs Nagy <szabolcs.nagy@arm.com>
CommitDate: 2018-01-15 13:28:25 +0000

     Fix gdb.texinfo more

     Add incorrectly removed @pindex back.

     gdb/doc/ChangeLog:

             * gdb.texinfo (gdb-add-index man): Add pindex.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: cherry picking documentation patches to 8.1 branch
  2018-05-09 16:01 cherry picking documentation patches to 8.1 branch Szabolcs Nagy
@ 2018-05-09 17:33 ` Eli Zaretskii
  2018-05-09 17:47   ` Joel Brobecker
  0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2018-05-09 17:33 UTC (permalink / raw)
  To: Szabolcs Nagy; +Cc: gdb-patches, nd, brobecker

> From: Szabolcs Nagy <szabolcs.nagy@arm.com>
> Date: Wed, 9 May 2018 17:00:55 +0100
> NoDisclaimer: True
> 
> hello, i'd like to backport these patches into the 8.1 branch:

Thanks, this is obviously fine with me.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: cherry picking documentation patches to 8.1 branch
  2018-05-09 17:33 ` Eli Zaretskii
@ 2018-05-09 17:47   ` Joel Brobecker
  2018-05-10 15:05     ` Szabolcs Nagy
  0 siblings, 1 reply; 4+ messages in thread
From: Joel Brobecker @ 2018-05-09 17:47 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Szabolcs Nagy, gdb-patches, nd

> > hello, i'd like to backport these patches into the 8.1 branch:
> 
> Thanks, this is obviously fine with me.

Excellent. But before you do the push, please make sure to have
a GDB/PR number, describing what the issues are, and with the target
milestone set to 8.1.1. Once you have that, if you could please add
that reference to the ChangeLog entries and commits' revision log.

Example of such a PR, which should link you to the attached commits,
and in particular how we put the GDB PR number in the ChangeLog and
revision log:

https://sourceware.org/bugzilla/show_bug.cgi?id=22849

(this is SOP for pushing patches to a release branch once the first
release off that branch has been made).

-- 
Joel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: cherry picking documentation patches to 8.1 branch
  2018-05-09 17:47   ` Joel Brobecker
@ 2018-05-10 15:05     ` Szabolcs Nagy
  0 siblings, 0 replies; 4+ messages in thread
From: Szabolcs Nagy @ 2018-05-10 15:05 UTC (permalink / raw)
  To: Joel Brobecker, Eli Zaretskii; +Cc: nd, gdb-patches

On 09/05/18 18:47, Joel Brobecker wrote:
>>> hello, i'd like to backport these patches into the 8.1 branch:
>>
>> Thanks, this is obviously fine with me.
> 
> Excellent. But before you do the push, please make sure to have
> a GDB/PR number, describing what the issues are, and with the target
> milestone set to 8.1.1. Once you have that, if you could please add
> that reference to the ChangeLog entries and commits' revision log.
> 
> Example of such a PR, which should link you to the attached commits,
> and in particular how we put the GDB PR number in the ChangeLog and
> revision log:
> 
> https://sourceware.org/bugzilla/show_bug.cgi?id=22849
> 
> (this is SOP for pushing patches to a release branch once the first
> release off that branch has been made).
> 

thanks,

meanwhile i realized i'm building from binutils-2_30-branch,
not the 8.1 branch (which is fine).

i assume gdb is still intended to be buildable from the
binutils branch, so i can ask binutils for a backport.

sorry for the noise.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-05-10  9:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-09 16:01 cherry picking documentation patches to 8.1 branch Szabolcs Nagy
2018-05-09 17:33 ` Eli Zaretskii
2018-05-09 17:47   ` Joel Brobecker
2018-05-10 15:05     ` Szabolcs Nagy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).