From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78416 invoked by alias); 16 May 2018 13:54:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77967 invoked by uid 89); 16 May 2018 13:53:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 May 2018 13:53:58 +0000 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4GDooUH106626 for ; Wed, 16 May 2018 09:53:57 -0400 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0a-001b2d01.pphosted.com with ESMTP id 2j0kcxym0b-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 16 May 2018 09:53:56 -0400 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 16 May 2018 14:53:54 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 16 May 2018 14:53:52 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4GDrqVr8716552; Wed, 16 May 2018 13:53:52 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E6871A4065; Wed, 16 May 2018 14:45:21 +0100 (BST) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D378FA4053; Wed, 16 May 2018 14:45:21 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.152.213.77]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 16 May 2018 14:45:21 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id AF6AFD80322; Wed, 16 May 2018 15:53:51 +0200 (CEST) Subject: Re: [PATCH 1/8] [PowerPC] Consolidate linux target description selection To: pedromfc@linux.vnet.ibm.com (Pedro Franco de Carvalho) Date: Wed, 16 May 2018 14:05:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20180510195840.17734-2-pedromfc@linux.vnet.ibm.com> from "Pedro Franco de Carvalho" at May 10, 2018 04:58:33 PM MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 18051613-0020-0000-0000-0000041DD5E2 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18051613-0021-0000-0000-000042B2F2DD Message-Id: <20180516135351.AF6AFD80322@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-16_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=9 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805160141 X-SW-Source: 2018-05/txt/msg00334.txt.bz2 Pedro Franco de Carvalho wrote: > gdb/ChangeLog: > yyyy-mm-dd Pedro Franco de Carvalho > > * arch/ppc-linux-common.c: New file. > * arch/ppc-linux-common.h: New file. > * arch/ppc-linux-tdesc.h: New file. > * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o. > * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o. > (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and > arch/ppc-linux-tdesc.h. > * ppc-linux-nat.c: Include arch/ppc-linux-common.h and > arch/ppc-linux-tdesc.h. > (ppc_linux_nat_target::read_description): Remove target > description matching code. Fill a ppc_linux_features struct and > call ppc_linux_match_description with it. Move comment about ISA > 2.05 to ppc-linux-common.c. > * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and > arch/ppc-linux-tdesc.h. > (ppc_linux_core_read_description): Remove target description > matching code. Fill a ppc_linux_features struct and call > ppc_linux_match_description with it. > * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l) > (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l) > (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l) > (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l) > (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l) > (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l) > (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l) > (tdesc_powerpc_e500l): Remove. > > gdb/gdbserver/ChangeLog: > yyyy-mm-dd Pedro Franco de Carvalho > > * configure.srv (srv_tgtobj): Add arch/ppc-linux-common.o. > * Makefile.in (SFILES): Add arch/ppc-linux-common.c. > * linux-ppc-tdesc.h: Rename to linux-ppc-tdesc-init.h. > * linux-ppc-tdesc-init.h (tdesc_powerpc_32l, tdesc_powerpc_64l) > (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l) > (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l) > (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l) > (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l) > (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l) > (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l) > (tdesc_powerpc_e500l): Remove. > * linux-ppc-ipa.c: Include arch/ppc-linux-tdesc.h and > linux-ppc-tdesc-init.h. Don't include linux-ppc-tdesc.h. > * linux-ppc-low.c: Include arch/ppc-linux-common.h, > arch/ppc-linux-tdesc.h, and linux-ppc-tdesc-init.h. Don't include > linux-ppc-tdesc.h. > (ppc_arch_setup): Remove target description matching code. Fill a > ppc_linux_features struct and call ppc_linux_match_description > with it. Thanks for doing this rework! The patch is mostly OK with me, except for this one bit: > +/* Base value for ppc_linux_features variables. */ > +const struct ppc_linux_features ppc_linux_no_features = { > + 4, > + false, > + false, > + false, > + false, > +}; I'm not sure it makes much sense to declare "4" the default wordsize -- there's not really a default between 4 and 8. Maybe it would be clearer to just force all users to explicitly set the wordsize. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com