From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27601 invoked by alias); 16 May 2018 14:05:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27589 invoked by uid 89); 16 May 2018 14:05:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Initialize X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 May 2018 14:05:50 +0000 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4GDvApr113063 for ; Wed, 16 May 2018 10:05:49 -0400 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0a-001b2d01.pphosted.com with ESMTP id 2j0ketqyte-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 16 May 2018 10:05:49 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 16 May 2018 15:05:46 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 16 May 2018 15:05:43 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4GE5hF71638706; Wed, 16 May 2018 14:05:43 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 979BA5204B; Wed, 16 May 2018 13:55:51 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.152.213.77]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 84EAD52043; Wed, 16 May 2018 13:55:51 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 25104D80322; Wed, 16 May 2018 16:05:43 +0200 (CEST) Subject: Re: [PATCH 6/8] [PowerPC] Fix VSX registers in linux core files To: pedromfc@linux.vnet.ibm.com (Pedro Franco de Carvalho) Date: Wed, 16 May 2018 14:18:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20180510195840.17734-7-pedromfc@linux.vnet.ibm.com> from "Pedro Franco de Carvalho" at May 10, 2018 04:58:38 PM MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 18051614-0044-0000-0000-00000553180D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18051614-0045-0000-0000-000028948658 Message-Id: <20180516140543.25104D80322@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-16_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805160141 X-SW-Source: 2018-05/txt/msg00336.txt.bz2 Pedro Franco de Carvalho wrote: > gdb/ChangeLog: > yyyy-mm-dd Pedro Franco de Carvalho > > * ppc-linux-tdep.c (ppc_linux_vsxregset): New function. > (ppc32_linux_vsxregmap): New global. > (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap, > regcache_supply_regset, and regcache_collect_regset. > * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare. > * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove. > (fetch_vsx_register, store_vsx_register): Remove. > (fetch_vsx_registers): Add regno parameter. Get regset using > ppc_linux_vsxregset. Use regset to supply registers. > (store_vsx_registers): Add regno parameter. Get regset using > ppc_linux_vsxregset. Use regset to collect registers. > (fetch_register): Call fetch_vsx_registers instead of > fetch_vsx_register. > (store_register): Call store_vsx_registers instead of > store_vsx_register. > (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the > new regno parameter. > (store_ppc_registers): Call store_vsx_registers with -1 for the > new regno parameter. > * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget) > (ppc_collect_vsxregset): Remove. > > gdb/testsuite/ChangeLog: > yyyy-mm-dd Pedro Franco de Carvalho > > * gdb.arch/powerpc-vsx-gcore.exp: New file. > + vsxregset->supply_regset(vsxregset, regcache, regno, ®s, > + PPC_LINUX_SIZEOF_VSXREGSET); Formatting. Otherwise, this is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com