Backport of patch to gdb 8.0 branch.

Backport of patch to gdb 8.0 branch.

[Tamar Christina]

Hi All,

I'm looking for a backport of https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=957f6b39cab6cac0e4c54e650c7f75109544ac1d
to the gdb-8.0-branch. The patch allows building with full debug trace enabled on AArch64.

Ok for gdb-8.0-branch?

Thanks,
Tamar

RE: Backport of patch to gdb 8.0 branch.

[Tamar Christina]

Hi Joel,

I'm looking to backport this change to fix builds with debug trace on the gdb-8.0 branch.

It's been backported to the binutils-2.30 branch already.

Kind Regards,
Tamar

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org <gdb-patches-
> owner@sourceware.org> On Behalf Of Tamar Christina
> Sent: Tuesday, May 15, 2018 18:00
> To: gdb-patches@sourceware.org
> Cc: nd <nd@arm.com>
> Subject: Backport of patch to gdb 8.0 branch.
> 
> Hi All,
> 
> I'm looking for a backport of
> https://sourceware.org/git/gitweb.cgi?p=binutils-
> gdb.git;a=commit;h=957f6b39cab6cac0e4c54e650c7f75109544ac1d
> to the gdb-8.0-branch. The patch allows building with full debug trace
> enabled on AArch64.
> 
> Ok for gdb-8.0-branch?
> 
> Thanks,
> Tamar

Re: Backport of patch to gdb 8.0 branch.

[Joel Brobecker]

> I'm looking for a backport of
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=957f6b39cab6cac0e4c54e650c7f75109544ac1d
> to the gdb-8.0-branch. The patch allows building with full debug trace
> enabled on AArch64.
> 
> Ok for gdb-8.0-branch?

If not already done so, please create a PR in bugzilla that explains
the problem this patch is fixing. Once this is done, can you add that
PR number to the ChangeLog and revision log of the commit you'd like
to backport?

Here is an example that shows a PR with associated commits:
https://sourceware.org/bugzilla/show_bug.cgi?id=22849

This is to follow part of our procedures aiming at properly documenting
all changes that go into a release branch after we make the first
release on that branch.

-- 
Joel

Re: Backport of patch to gdb 8.0 branch.

[Tamar Christina]

[-- Attachment #1: Type: text/plain, Size: 1384 bytes --]

Hi Joel,

The build with debug tracing enabled (`-DDEBUG_AARCH64`)
is currently broken. A variable that no longer exists is being
referenced from the debug statement.

Compiled on aarch64-none-linux-gnu and no issues,


This patch already exists in master and 8.1 branches as
957f6b39cab6cac0e4c54e650c7f75109544ac1d.

Ok for gdb-8.0-branch?

opcodes/
2018-05-18  Tamar Christina  <tamar.christina@arm.com>

	PR gdb/23200
	* aarch64-opc.c (aarch64_logical_immediate_p): Update
	DEBUG_TRACE arguments.

Thanks,
Tamar

The 05/17/2018 18:16, Joel Brobecker wrote:
> > I'm looking for a backport of
> > https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=957f6b39cab6cac0e4c54e650c7f75109544ac1d
> > to the gdb-8.0-branch. The patch allows building with full debug trace
> > enabled on AArch64.
> > 
> > Ok for gdb-8.0-branch?
> 
> If not already done so, please create a PR in bugzilla that explains
> the problem this patch is fixing. Once this is done, can you add that
> PR number to the ChangeLog and revision log of the commit you'd like
> to backport?
> 
> Here is an example that shows a PR with associated commits:
> https://sourceware.org/bugzilla/show_bug.cgi?id=22849
> 
> This is to follow part of our procedures aiming at properly documenting
> all changes that go into a release branch after we make the first
> release on that branch.
> 
> -- 
> Joel

-- 

[-- Attachment #2: rb7390-gdb.patch --]
[-- Type: text/x-diff, Size: 579 bytes --]

diff --git a/opcodes/aarch64-opc.c b/opcodes/aarch64-opc.c
index cc99c101236c542ff94bb9c0abc09df521ced330..a52ea70c0093f7daaecfd58e3f0e81a3953abf5f 100644
--- a/opcodes/aarch64-opc.c
+++ b/opcodes/aarch64-opc.c
@@ -1204,8 +1204,8 @@ aarch64_logical_immediate_p (uint64_t value, int esize, aarch64_insn *encoding)
   uint64_t upper;
   int i;
 
-  DEBUG_TRACE ("enter with 0x%" PRIx64 "(%" PRIi64 "), is32: %d", value,
-	       value, is32);
+  DEBUG_TRACE ("enter with 0x%" PRIx64 "(%" PRIi64 "), esize: %d", value,
+	       value, esize);
 
   if (initialized == FALSE)
     {

Re: Backport of patch to gdb 8.0 branch.

[Joel Brobecker]

> This patch already exists in master and 8.1 branches as
> 957f6b39cab6cac0e4c54e650c7f75109544ac1d.
> 
> Ok for gdb-8.0-branch?
> 
> opcodes/
> 2018-05-18  Tamar Christina  <tamar.christina@arm.com>
> 
> 	PR gdb/23200
> 	* aarch64-opc.c (aarch64_logical_immediate_p): Update
> 	DEBUG_TRACE arguments.

Yes, you can go right ahead.


> diff --git a/opcodes/aarch64-opc.c b/opcodes/aarch64-opc.c
> index cc99c101236c542ff94bb9c0abc09df521ced330..a52ea70c0093f7daaecfd58e3f0e81a3953abf5f 100644
> --- a/opcodes/aarch64-opc.c
> +++ b/opcodes/aarch64-opc.c
> @@ -1204,8 +1204,8 @@ aarch64_logical_immediate_p (uint64_t value, int esize, aarch64_insn *encoding)
>    uint64_t upper;
>    int i;
>  
> -  DEBUG_TRACE ("enter with 0x%" PRIx64 "(%" PRIi64 "), is32: %d", value,
> -	       value, is32);
> +  DEBUG_TRACE ("enter with 0x%" PRIx64 "(%" PRIi64 "), esize: %d", value,
> +	       value, esize);
>  
>    if (initialized == FALSE)
>      {
> 


-- 
Joel