From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106545 invoked by alias); 18 May 2018 09:46:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106452 invoked by uid 89); 18 May 2018 09:46:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=(unknown) X-HELO: EUR02-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr20077.outbound.protection.outlook.com (HELO EUR02-VE1-obe.outbound.protection.outlook.com) (40.107.2.77) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 09:46:08 +0000 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Tamar.Christina@arm.com; Received: from arm.com (217.140.96.140) by HE1PR08MB0537.eurprd08.prod.outlook.com (2a01:111:e400:50a7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Fri, 18 May 2018 09:46:00 +0000 Date: Fri, 18 May 2018 10:57:00 -0000 From: Tamar Christina To: Joel Brobecker Cc: "gdb-patches@sourceware.org" , nd Subject: Re: Backport of patch to gdb 8.0 branch. Message-ID: <20180518094554.GA18416@arm.com> References: <20180517171644.7n46a6flnuuz23en@adacore.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="wRRV7LY7NUeQGEoC" Content-Disposition: inline In-Reply-To: <20180517171644.7n46a6flnuuz23en@adacore.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-ClientProxiedBy: CWXP265CA0044.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:2d::32) To HE1PR08MB0537.eurprd08.prod.outlook.com (2a01:111:e400:50a7::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(49563074)(7193020);SRVR:HE1PR08MB0537; X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0537;3:rFFxL7eheWbA/vjtr3/BHNg7W2m6c/XxC2JALZtLrb2pU3c/TKg7Q+xj4cu52z7GLKIuUn/diEhKJlF4vz13XdKGSC6TEYkdnzIswVDofKqg1nseTyRnPtsQ121xGEjHAMBdXDks6lfEk8FLWgV5RqwvkXOa8xqvuoXIfqRO4iva6kfWysg4NPDNjzFYREu2K3U7DQ8wq03GUBQv7VNuK4kCzibSQiX2R6y6S5kXq/tjszqX0PDdhXIsdeU8VFyN;25:Pdhj6uDYunVnuyQfQSY1PhS4idUJdussb4+Rc31rX/Z80ihhHzNNAXUve/nh9WvGwNVFJMmImYZ7ge9ysTgMXM17bNudwh+g7Cxo60Et7ug1fsClE5MWPfRsxC4jDyW+N4aXJNS8IQauDYFj3B6MOHhc+YNaPVkZBDKwgqEkg0zcTKeP4MK0Cq/SAijTBhgVEY3EdiNEOFhfMvNEoMMv/354rtwehtccxyaU0Sl06zhl6Hk4El4j0YzQKsbIMssgxLGbiFs9pN198qGWyC6El14KZJT0aEHSNPf5wfXG/JIZ65zUQ2hhLgSIrkVjdFa17XUU0GOI7cySJWo7Y+FcSQ==;31:oD+FbcrhFZ6GvH+CIfEmc3deUMJqwqDGN+wo/mhPXuZtS7P0mVXCrobBlc7ZXGCBHNOMbTsSsv9Qwy0qv7W+CC5J23xjgcJa/ByKiPrOjqJnX7xkU7LwjOMBPci+VZRUw3L3KGyRNOyebML2FfeBoeb5XIHK51WPwbnpdSzl1OvnOX+kpl7JIxFHb1yQzszb234rv+lPCNtpT6cGRXBT9Jo6uvLKNeNlTH40jTxTHl0= X-MS-TrafficTypeDiagnostic: HE1PR08MB0537: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0537;20:qymV7xPjc+xV8LnbfcyzjN6zRwhJ8+jpp4yvk1Tfs/g22zFrNpDiDYHX0/KGypNgxTZFzr0l3O2yZk6I5MXI9NNvQFTFpnW2mrHSpj6uPlIk8CvLVNBl4aA5ySQgwboDqYM+63J3Nyuo3zq4CUdSD9dAJ3Zd7EmnHwsfmjCzpbFqxvx2mwO8FhFZwGE/I8QrjLd4vcNJ/aZMmUOCuNWlAwpq4qxmZUyCLEpFCKqN1tgJzKuH+zWaPzKNQCybDHrS;4:ujyDEIOH3kYd5ujXM/nEUL1N3RVMRwMn1Xa/a58WM9gAjNhnMtqHhXo64nrwTzxb8rJsPpLhmMFrHVYDDhmZKUEarz0yVTniPD9ycAVSQ8f9hdR/i/gfW2sVsNzUCZ/o+nvU4qgzcbm2y3tKB1SHddxDnbnBlG6RZZC5SOIyKLHiV/+1+UadA7Fk3UYBy8bZEqzpQ8h5u19juPcCIRxo4zduD5drHW1+7tplMn7/p31Usj4Vw0L5HnCBQmd/fSw6sKNIwBPAVLw00YBHSuIFgbq5TIVcIUk82OggEV6hjZd1zgvnNb6m+nyOU/VHeMqH X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(102415395)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016);SRVR:HE1PR08MB0537;BCL:0;PCL:0;RULEID:;SRVR:HE1PR08MB0537; X-Forefront-PRVS: 0676F530A9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(366004)(376002)(396003)(346002)(39380400002)(39860400002)(377424004)(189003)(199004)(54534003)(33656002)(76176011)(86362001)(575784001)(105586002)(52116002)(7696005)(476003)(2616005)(956004)(26005)(66066001)(11346002)(486006)(446003)(386003)(59450400001)(16526019)(44144004)(33964004)(72206003)(966005)(6666003)(25786009)(568964002)(5890100001)(6246003)(53936002)(4326008)(305945005)(2906002)(186003)(7736002)(478600001)(68736007)(2476003)(4610100001)(84326002)(6116002)(3846002)(1076002)(229853002)(81166006)(8936002)(81156014)(8676002)(54906003)(58126008)(16586007)(316002)(5660300001)(6916009)(36756003)(55016002)(106356001)(21086003)(97736004)(6306002)(18370500001)(2700100001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR08MB0537;H:arm.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR08MB0537;23:PGqZMnu/bWfG7UZ0ilF/jZFGSwDHFHY+ctO5NME6u?= =?us-ascii?Q?BBNle17T34uUyXhfOi2NAKp1xWM7hj25ZRt5P/XwMBTu8g9Q2Rc3AtxWgTAb?= =?us-ascii?Q?fUS/CSHYWpJCg/Wxevm8p6zXib1qmjHsCtJzsJ0pphI3xOJNx5Db/64EAiew?= =?us-ascii?Q?HFmDU/3Kbv48zcsVO+nSpUu8TQ2XozLRskJ4LIJw3vVjSYZoJ8M/Qcf3A+lH?= =?us-ascii?Q?cLD5Afz2ALG2Vhjv25U60H6LeMwS72WVCl8V5O5pnyeqKE7yrDd3XvN+AexZ?= =?us-ascii?Q?A43mGcg2DCAloRhEeJMZyXp/qIKZGf/KJrwc4XxbNsqoN5CpwSG5DBIb/03J?= =?us-ascii?Q?x5n3SSSIARK3JgxCnxShljv8ndmgSbimV8s1MKwXBYrbcFZ20TF22bUomBxN?= =?us-ascii?Q?gveexVzFJaXHH3zXlDFJa75iQLq3OurpO2QuVyF3e4Ozwi36bPw2Y/C+aUmN?= =?us-ascii?Q?ZDmw8JZ1ZbqBti0gjYzL1ZgFhgY8Cu8w8VdcXgCSy2b5iyGN+lbj2snI8NEz?= =?us-ascii?Q?tx/NgQU7FaLAJACE5cFs23zh1rNBqoJqO30jFin218qK+Jr5pqu+HydnGgri?= =?us-ascii?Q?Hz7EDsJc0534Myj65vFKh4eMsUxjBG8Ic7tTNLO8VZXvC9+oo4Xm7gtdmYUl?= =?us-ascii?Q?dJ2UfPeNXHr1B2JqPFqHp24vWYRGkjWqDq6FkulKcwj1gg5zAPRA6pDH8m3D?= =?us-ascii?Q?uqpu+cCrrlUD3POCypYLIic+QJNM07+JOeXqNqP09KK+m+h2lAhouXv8tOiq?= =?us-ascii?Q?GTOvw3dZecZy4WqMNJl7pXSHYHneeUTrOSYGuL4BwIz8DQ47aR36YbdYBgzP?= =?us-ascii?Q?f3d4entSQxPzazaMBVYwY4Mo2NcEOpffcj/pvM057+hUg60n1jo8MGBUxM7T?= =?us-ascii?Q?iNN1PVqkkMSp+nKL2+bFuFSVre3ypEZP+7kTXp+EIW6nHIH1hpPMdIHPII3N?= =?us-ascii?Q?x5rg32XXtXeenO34V0vnJlxeIIJ+zDu6hdRP4P/w3jP9Q+QKMay8ScabU19B?= =?us-ascii?Q?r4dT54tWCX8qilaNfj9AfefHUWKL3nbEe5WYRnVQcQqE7yFp8eLjwSCrQ4EB?= =?us-ascii?Q?vTVTOW9jk8t1UhrSPOIGn4wTQkQ3wI9EdxcbMuZ7Af9Ww6YRnotdpjE3Va/I?= =?us-ascii?Q?jMFERdrW2F5WI9b56z2BV1FkgsolHLUZmNML3ivKQOyyXbiYQPIXme+vz33m?= =?us-ascii?Q?nvtGIAMDbchgLgE4JZ67laG+Bq5vyBhQcWFtLxOdKU4fHQ6wnyP1QyNLGwUl?= =?us-ascii?Q?wIFGdOY2kgvnPpyJDmpqoGLRoehdQ104DpyqB9K+gI9jO0LSqTlhw8NMRvx6?= =?us-ascii?Q?l6g/mEKCPn0Q4+H6C+DxLgulx8wwpb3RsPrF61SQ5G4QNY4qKZKd7DL2YmBR?= =?us-ascii?Q?xtX6cxB+KX4Paw/aj9YxvSx1Ql7js+nFfQW2XZv97c7sCLRML0FRsaknr4c3?= =?us-ascii?Q?RIWK0M5uktrQlS5AFJjdkUs11dnMwXS5fCkaR/zMV8rMlsqRNi+Wvl56JnOu?= =?us-ascii?Q?Nm5KQG8xYpa9YAftzbOvHBLC+xDE3SjmUbp02zMJJIyzaxn6O05p1aaWICNH?= =?us-ascii?Q?ooqiPLF3RHeLcAfCbSiliYNVpLNqK0QTGWGtTo=3D?= X-Microsoft-Antispam-Message-Info: rLxUnB53djG92dVU3zE67o4D0mqocA0ieddJPmIyU+p6ClH3tk6M/SIh0O120UXjL7UaqRWKeS2NYMPJHFuUm6VXx+48snaZaIg24xObvphqlQCRnWlTy8NEDg3tSomV0lqavzOZpnnJvvuFmZkQ2hBfYB/SsEX0mryOkkyz1dWCfhhEzHBt04lDJ8ESwvst X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0537;6:pMG9rfSJAQUeI6H4/neFVqoJZO7/Zp1Ls6NJSA2r695DkJP/IxR3MxFIqe/nCy61wUltIeoWITaGAWUwguYQE4H/gIU8gE8Dan0YNro6BD/hozQEARUXWS12+gTIfGgMaOdJ5ZlcgSZ+zOsiSi8DOiCWkAiK1lABbSWY+k72NnaJ7xD4ZlEfap2QfMhsH4afqy5tmNWRzHzst/auJFVOQMHUb77wZUaWQKOzzpFRIwXgr13STbtNFgFeTaGad2MYAdgCUS3Mso4jHG2OfVvA4TnbZbuIRfYPquQwon+LpVJahXhFJT9auA01+59p4ad1AC2MBrLC8wyC6wUjpfVxhiBoB/jXz5/sNI8nmzNmf3+hc828LARCWqAN4UqrXyeB/9mQ6molM/QEVDCX1McFH0687egUTTRQzSzXWTmCJezuBBaGprq8U+y+mRF7akS6TIzrc7x6/I9E5tRLBc0UoA==;5:p6uK53LueojX+JDGTQSpmsSAogcoIsu4QogtUCU3vorpR20ejzXAOY7DpuJfqLsud6sGMF8x2lXhqndihaWcw9Dy4wfh7hNqwUE7/CCNKGBPQVZjOPFvKbo3gxjaJAdfRiTSQ0lLxwzAkhGZ/c5gb+QIVkJRuB1alEia405x2kc=;24:AEEmyk+5ngyUWXvB1/kTrw16n8Olv0aV1F6BiW6zyI0ew1P0u57xZpkiPfBZd9cXkJXEjP9wkvodUymUiQBInCnzY9DPTllT5M0rbIsBmEs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0537;7:9hqr6pQRthNcslsx8c46l7zP+7RX3KAkokEEC8W7/2AMSvsbDhY8kal84V+vqieoqYFrMB+M/7fcSkg5Newnd8VyMkU6BgP9P8r9RJWZX1opPKssBF1rh4ivHVEHTIorDdaiMTtqLmxVb870ruq7AAoXSo2DDnUFPw3Xrbu1LSC0duW+Ds8Q/5rtxIMmuXiCuJ+gnlBPx8rXIKBykzObcuCPjGsiXAbpYlBOKFjSEmCXKfOfZO4YYgwipTbwfJEM X-MS-Office365-Filtering-Correlation-Id: 11f13943-dd58-41f9-aaff-08d5bca429c8 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2018 09:46:00.1499 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11f13943-dd58-41f9-aaff-08d5bca429c8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB0537 X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00401.txt.bz2 --wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-length: 1384 Hi Joel, The build with debug tracing enabled (`-DDEBUG_AARCH64`) is currently broken. A variable that no longer exists is being referenced from the debug statement. Compiled on aarch64-none-linux-gnu and no issues, This patch already exists in master and 8.1 branches as 957f6b39cab6cac0e4c54e650c7f75109544ac1d. Ok for gdb-8.0-branch? opcodes/ 2018-05-18 Tamar Christina PR gdb/23200 * aarch64-opc.c (aarch64_logical_immediate_p): Update DEBUG_TRACE arguments. Thanks, Tamar The 05/17/2018 18:16, Joel Brobecker wrote: > > I'm looking for a backport of > > https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=957f6b39cab6cac0e4c54e650c7f75109544ac1d > > to the gdb-8.0-branch. The patch allows building with full debug trace > > enabled on AArch64. > > > > Ok for gdb-8.0-branch? > > If not already done so, please create a PR in bugzilla that explains > the problem this patch is fixing. Once this is done, can you add that > PR number to the ChangeLog and revision log of the commit you'd like > to backport? > > Here is an example that shows a PR with associated commits: > https://sourceware.org/bugzilla/show_bug.cgi?id=22849 > > This is to follow part of our procedures aiming at properly documenting > all changes that go into a release branch after we make the first > release on that branch. > > -- > Joel -- --wRRV7LY7NUeQGEoC Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="rb7390-gdb.patch" Content-length: 579 diff --git a/opcodes/aarch64-opc.c b/opcodes/aarch64-opc.c index cc99c101236c542ff94bb9c0abc09df521ced330..a52ea70c0093f7daaecfd58e3f0e81a3953abf5f 100644 --- a/opcodes/aarch64-opc.c +++ b/opcodes/aarch64-opc.c @@ -1204,8 +1204,8 @@ aarch64_logical_immediate_p (uint64_t value, int esize, aarch64_insn *encoding) uint64_t upper; int i; - DEBUG_TRACE ("enter with 0x%" PRIx64 "(%" PRIi64 "), is32: %d", value, - value, is32); + DEBUG_TRACE ("enter with 0x%" PRIx64 "(%" PRIi64 "), esize: %d", value, + value, esize); if (initialized == FALSE) { --wRRV7LY7NUeQGEoC--