From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19804 invoked by alias); 22 May 2018 12:56:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104078 invoked by uid 89); 22 May 2018 12:45:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 May 2018 12:45:25 +0000 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4MCiqWK133170 for ; Tue, 22 May 2018 08:45:23 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 2j4grnfw0h-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 22 May 2018 08:45:23 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 22 May 2018 13:45:21 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 22 May 2018 13:45:18 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4MCjIPR5046604; Tue, 22 May 2018 12:45:18 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E1E4FA4055; Tue, 22 May 2018 13:36:39 +0100 (BST) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D0563A4040; Tue, 22 May 2018 13:36:39 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.152.213.77]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 22 May 2018 13:36:39 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id B801BD804DB; Tue, 22 May 2018 14:45:17 +0200 (CEST) Subject: Re: [PATCH v2 5/8] [PowerPC] Fix access to VSCR in linux targets To: pedromfc@linux.vnet.ibm.com (Pedro Franco de Carvalho) Date: Tue, 22 May 2018 12:56:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20180521204458.19070-5-pedromfc@linux.vnet.ibm.com> from "Pedro Franco de Carvalho" at May 21, 2018 05:44:55 PM MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 18052212-0040-0000-0000-0000045C2561 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18052212-0041-0000-0000-0000210076F3 Message-Id: <20180522124517.B801BD804DB@oc3748833570.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-22_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805220149 X-SW-Source: 2018-05/txt/msg00548.txt.bz2 Pedro Franco de Carvalho wrote: > gdb/ChangeLog: > yyyy-mm-dd Pedro Franco de Carvalho > > * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register > offset fields. > * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers > for vector register offset fields. > (ppc64_fbsd_reg_offsets): Likewise. > * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment > to vector register offset fields. > * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment > to vector register offset fields. > * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to > vector register offset fields. > * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove > initializers for vector register offset fields. > (rs6000_aix64_reg_offsets): Likewise. > * rs6000-tdep.c (ppc_vrreg_offset): Remove. > (ppc_supply_vrregset): Remove. > (ppc_collect_vrregset): Remove. > * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function. > (ppc_linux_vrregset) : New function. > (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap) > (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals. > (ppc32_linux_vrregset): Remove. > (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset > and use result instead of ppc32_linux_vrregset. > (ppc32_linux_reg_offsets): Remove initializers for vector register > offset fields. > (ppc64_linux_reg_offsets): Likewise. > * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration. > * ppc-linux-nat.c: Include regset.h. > (gdb_vrregset_t): Adjust comment to account for little-endian > mode. > (supply_vrregset, fill_vrregset): Remove. > (fetch_altivec_register, store_altivec_register): Remove. > (fetch_altivec_registers): Add regno parameter. Get regset using > ppc_linux_vrregset. Use regset to supply registers. > (store_altivec_registers): Add regno parameter. Get regset using > ppc_linux_vrregset. Use regset to collect registers. > (fetch_register): Call fetch_altivec_registers instead of > fetch_altivec_register. > (store_register): Call store_altivec_registers instead of > store_altivec_register. > (fetch_ppc_registers): Call fetch_altivec_registers with -1 for > the new regno parameter. > (store_ppc_registers): Call store_altivec_registers with -1 for > the new regno parameter. > > gdb/gdbserver/ChangeLog: > yyyy-mm-dd Pedro Franco de Carvalho > > * linux-ppc-low.c (ppc_fill_vrregset): Add vscr_offset variable. > Set vscr_offset to 0 in little-endian mode and 12 in big-endian > mode. Call collect_register_by_name with vscr using > vscr_offset. Zero-pad vscr and vrsave fields in collector buffer. > (ppc_store_vrregset): Add and set vscr_offset variable as in > ppc_fill_vrregset. Call supply_register_by_name with vscr using > vscr_offset. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com