From: Joel Brobecker <brobecker@adacore.com>
To: Omair Javaid <omair.javaid@linaro.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2][PR gdb/23210] Unset gdbarch significant_addr_bit by default
Date: Tue, 29 May 2018 19:52:00 -0000 [thread overview]
Message-ID: <20180529175804.ysbdan74mzzpo33s@adacore.com> (raw)
In-Reply-To: <1527296331-32213-1-git-send-email-omair.javaid@linaro.org>
Hi Omar,
On Sat, May 26, 2018 at 05:58:51AM +0500, Omair Javaid wrote:
> This version fixes the typo and gdbarch.sh issue highlighted in review.
>
> LGTM?
>
> This patch fixes a bug introduced by fix to AArch64 pointer tagging.
>
> In our fix for tagged pointer support our agreed approach was to sign
> extend user-space address after clearing tag bits. This is not same
> for all architectures and this patch allows sign extension for
> addresses on targets which specifically set significant_addr_bit.
>
> More information about patch that caused the issues and discussion
> around tagged pointer support can be found in links below:
>
> https://sourceware.org/ml/gdb-patches/2018-05/msg00000.html
> https://sourceware.org/ml/gdb-patches/2017-12/msg00159.html
>
> gdb/ChangeLog:
>
> 2018-05-23 Omair Javaid <omair.javaid@linaro.org>
>
> * gdbarch.sh (significant_addr_bit): Default to zero when
> not set by target architecture.
> * gdbarch.c: Re-generated.
> * utils.c (address_significant): Update.
In addition to Pedro's comments, can you make sure you add "PR
gdb/23210" to the ChangeLog entry?
--
Joel
prev parent reply other threads:[~2018-05-29 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-26 1:25 Omair Javaid
2018-05-29 13:12 ` Pedro Alves
2018-05-29 19:52 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529175804.ysbdan74mzzpo33s@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=omair.javaid@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).