From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29714 invoked by alias); 29 May 2018 17:58:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29702 invoked by uid 89); 29 May 2018 17:58:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=our X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 May 2018 17:58:07 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3E4575607E; Tue, 29 May 2018 13:58:06 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id jUN59m-NgVd6; Tue, 29 May 2018 13:58:06 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0B2415606A; Tue, 29 May 2018 13:58:06 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1796383056; Tue, 29 May 2018 10:58:04 -0700 (PDT) Date: Tue, 29 May 2018 19:52:00 -0000 From: Joel Brobecker To: Omair Javaid Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2][PR gdb/23210] Unset gdbarch significant_addr_bit by default Message-ID: <20180529175804.ysbdan74mzzpo33s@adacore.com> References: <1527296331-32213-1-git-send-email-omair.javaid@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1527296331-32213-1-git-send-email-omair.javaid@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-05/txt/msg00776.txt.bz2 Hi Omar, On Sat, May 26, 2018 at 05:58:51AM +0500, Omair Javaid wrote: > This version fixes the typo and gdbarch.sh issue highlighted in review. > > LGTM? > > This patch fixes a bug introduced by fix to AArch64 pointer tagging. > > In our fix for tagged pointer support our agreed approach was to sign > extend user-space address after clearing tag bits. This is not same > for all architectures and this patch allows sign extension for > addresses on targets which specifically set significant_addr_bit. > > More information about patch that caused the issues and discussion > around tagged pointer support can be found in links below: > > https://sourceware.org/ml/gdb-patches/2018-05/msg00000.html > https://sourceware.org/ml/gdb-patches/2017-12/msg00159.html > > gdb/ChangeLog: > > 2018-05-23 Omair Javaid > > * gdbarch.sh (significant_addr_bit): Default to zero when > not set by target architecture. > * gdbarch.c: Re-generated. > * utils.c (address_significant): Update. In addition to Pedro's comments, can you make sure you add "PR gdb/23210" to the ChangeLog entry? -- Joel