public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Add basic Python API for convenience variables
Date: Wed, 30 May 2018 23:14:00 -0000	[thread overview]
Message-ID: <20180530230505.rikgb3v6zkywsmnl@adacore.com> (raw)
In-Reply-To: <20180422211309.31251-1-tom@tromey.com>

Hi Tom,

> This adds a basic Python API for accessing convenience variables.
> With this, convenience variables can be read and set from Python.
> Although gdb supports convenience variables whose value changes at
> each call, this is not exposed to Python; it could be, but I think
> it's just as good to write a convenience function in this situation.
> 
> This is PR python/23080.
> 
> Tested on x86-64 Fedora 26.
> 
> ChangeLog
> 2018-04-22  Tom Tromey  <tom@tromey.com>
> 
> 	PR python/23080:
> 	* NEWS: Update for new functions.
> 	* python/py-value.c (gdbpy_set_convenience_variable)
> 	(gdbpy_convenience_variable): New functions.
> 	* python/python-internal.h (gdbpy_convenience_variable)
> 	(gdbpy_set_convenience_variable): Declare.
> 	* python/python.c (python_GdbMethods): Add convenience_variable,
> 	set_convenience_variable.
> 
> doc/ChangeLog
> 2018-04-22  Tom Tromey  <tom@tromey.com>
> 
> 	PR python/23080:
> 	* python.texi (Basic Python): Document gdb.convenience_variable,
> 	gdb.set_convenience_variable.
> 
> testsuite/ChangeLog
> 2018-04-22  Tom Tromey  <tom@tromey.com>
> 
> 	PR python/23080:
> 	* gdb.python/python.exp: Add convenience variable tests.

Really very sorry about the delay. The patch looks good to me,
so go ahead and push.

Thanks!
-- 
Joel

      parent reply	other threads:[~2018-05-30 23:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-22 21:13 Tom Tromey
2018-04-23 16:53 ` Eli Zaretskii
2018-04-30 13:11 ` Phil Muldoon
2018-05-09 15:43 ` Tom Tromey
2018-05-25 17:31   ` Tom Tromey
2018-05-30 23:14 ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530230505.rikgb3v6zkywsmnl@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).