Re: [RFA 2/4] Thread language through c_type_print_args

[Joel Brobecker <brobecker@adacore.com>]

> Currently dwarf2read.c will pass the CU's language to
> c_type_print_args -- but this doesn't affect all aspects of type
> printing, because some code in c-typeprint.c refers to
> current_language.
> 
> This patch threads the language through more of the type printing
> code, adding an overload to c_type_print.  Some uses of
> current_language remain, but now they are only in top-level functions.
> 
> ChangeLog
> 2018-04-17  Tom Tromey  <tom@tromey.com>
> 
> 	* dwarf2read.c (dwarf2_compute_name): Pass CU's language to
> 	c_print_type.
> 	* c-typeprint.c (c_print_type_1): Add "language" parameter.
> 	(c_print_type): Update.
> 	(c_print_type): New overload.
> 	(c_type_print_varspec_prefix, c_type_print_args)
> 	(c_type_print_varspec_suffix, c_print_type_no_offsets)
> 	(c_type_print_base_struct_union, c_type_print_base_1)
> 	(cp_type_print_method_args): Add "language" parameter.
> 	(c_type_print_base): Update.
> 	* c-lang.h (c_print_type): Add new overload.

Neat use of overloading to avoid having to manage a potentially
large number of callers all at once...

You mentioned as a follow up that you were wondering about putting
the language in struct type_print_options. I can see why it is
an option, and I wouldn't object to it, but at the moment, the
approach with adding it as a parameter feels better. I think it's
more consistent with what we've been doing before. I could be
convinced otherwise.

In the meantime, this patch is approved.

-- 
Joel