Hi Pedro, > It looks good to me. A few comments on minor details follow. > > How about naming the testcase list-thread-groups-no-inferior.exp > (no "mi-") so that it sits side-by-side with > list-thread-groups-available.exp? Good idea. Done. > We're missing an intro comment in the .exp file mentioning what the > testcase is about, otherwise it's not clear why we have two separate > testcases for seemingly the same thing. Also added. Let me know if you think it's not enough information, and I will add more. That's all I could think of from my perspective, though. > A couple microscopic nits more: > > > +gdb_test_multiple $test $test { > > + -re ".*\}" { > > Leading ".*" is not necessary, it's implied. Thanks - fixed! > > > +mi_gdb_test "-data-evaluate-expression 1" \ > > + ".*\\^done,value=\"1\"" \ > > + "check GDB is still alive" > > + > > "check" and "test" in test messages is one of my pet peeves. > OK, I'm really exaggerating. :-) The point is that all > tests are checking something, making it redundant. > "GDB is still alive" or even "GDB is alive" says the same. True, and I like it when it's shorter-with-no-loss. Fixed as well. Attached is the version I just pushed. I'll make further adjustments if you see something I missed or the description isn't complete for you. Thanks again! -- Joel