From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18181 invoked by alias); 4 Jun 2018 21:57:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18127 invoked by uid 89); 4 Jun 2018 21:57:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=topic, road X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Jun 2018 21:57:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 569085613D; Mon, 4 Jun 2018 17:57:54 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id p+IRiSDI6lPi; Mon, 4 Jun 2018 17:57:54 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 232C05612F; Mon, 4 Jun 2018 17:57:54 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 6468F808EA; Mon, 4 Jun 2018 14:57:52 -0700 (PDT) Date: Mon, 04 Jun 2018 21:57:00 -0000 From: Joel Brobecker To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: GDB 8.1.1 release, 2018-05-30 update Message-ID: <20180604215752.pitg7fgvmdqw73fr@adacore.com> References: <20180530222013.5pvgedo2moxlvmbf@adacore.com> <20180604211800.h7nh2nifhuauberg@adacore.com> <6b81ad5a-0195-58e9-083c-535c505acb0c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b81ad5a-0195-58e9-083c-535c505acb0c@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-06/txt/msg00086.txt.bz2 > Yeah, I've pretty much given up on triggering the exact conditions > that cause a user-visible manifestation of this bug. I have a dwarf > assembler file that I've been hacking at, and it is getting *quite* > large. Still no luck in causing this bug to trigger. > > However, I have been thinking about an alternative, easier way to > trigger the bug. That is by wrapping add_symbol_to_list in > dwarf2read.c with a custom version that checks if we are adding > symbols to a language_minimal dictionary. If it sees that, it issues a > complaint. [Or add another option to turn this on/off.] > > Once again that adds complexity into an already performance-sensitive > area, and I'm not really sure it is worth the effort anymore. Not to > mention how hacky it is! > > So really, I can continue down this road, or maintainers can make the > call to omit a test case for it entirely. Otherwise, I'll return my > attention to helping with the patch review backlog. Why not submit the patch as is, without a testcase? Then, leave it to me to rally the other maintainers to weigh in on the topic ;-). The alternative option you suggest is kind of interesting; I would have a hard time evaluating the performance impact without actually doing some measurements. It could be unnoticeable, particularly when building with optimization and inlining (I'm thinking that the extra wrapper could be reduced to one test instruction or two when complaints are off). -- Joel