From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6875 invoked by alias); 6 Jun 2018 08:22:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6835 invoked by uid 89); 6 Jun 2018 08:22:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=viewed, HX-Received:sk:k14-v6m, Personally X-HELO: mail-wr0-f179.google.com Received: from mail-wr0-f179.google.com (HELO mail-wr0-f179.google.com) (209.85.128.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Jun 2018 08:22:16 +0000 Received: by mail-wr0-f179.google.com with SMTP id f16-v6so5262082wrm.3 for ; Wed, 06 Jun 2018 01:22:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Sob9qCwNOpjFANAEpLaOj8BdGx4kCBUXbMAFvIvMYKw=; b=Rwwxk8y/yU60CKTVoeHMToUDolZJYEmIWLCIGgQ79OIOX1z64n64XNeHxUgN8xOU38 90tk8YFMHBaQ8n8UoF2JpBRVaTuAlunkt7Yc2097184j1D2u78i1KxnfoIxtA+0LZrAi L8cgGXFx9dx+4VLXfNLS6OMCOnaxxPNKYcsbq4kwlvVeuON577J7nZink1ebHH2zpuGd qe02h04iwPreBgpifv8kxoguMpXwgND0nX96kGpZR8nYhOJFHJYIPENvsrrtPlQxg38t V0yzN5wzrjTUmPUCeKQt0h46aro9ETqJI7Z6U16C/TCX1ozq0ZQhQ58KBi/+Q2LJM54E Z8Fg== X-Gm-Message-State: APt69E2gKOV6Pk9YX1QXfZX0IsMtKKSW7X8rB12x+b/8+Ei7rtLEu7zy zabRSpdRGkziW9uWPlosPqE9JQ== X-Google-Smtp-Source: ADUXVKJGS0yIDe+TOT4ttu7QDytfzRbMYlOXSf/083UcxcD5yKvV3Je+9VLUpk8fcojO2IYRoth6gQ== X-Received: by 2002:adf:c70e:: with SMTP id k14-v6mr1377064wrg.16.1528273334081; Wed, 06 Jun 2018 01:22:14 -0700 (PDT) Received: from localhost ([80.175.9.218]) by smtp.gmail.com with ESMTPSA id h4-v6sm10828831wre.89.2018.06.06.01.22.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Jun 2018 01:22:13 -0700 (PDT) Date: Wed, 06 Jun 2018 08:22:00 -0000 From: Andrew Burgess To: Eli Zaretskii Cc: Philippe Waroquiers , gdb-patches@sourceware.org Subject: Re: [PATCHv2 2/2] gdb: Change how frames are selected for 'frame' and 'info frame'. Message-ID: <20180606082211.GF15881@embecosm.com> References: <63020671a997f926cd747677cd4e614e51e81f8d.1525797846.git.andrew.burgess@embecosm.com> <83k1sanw3t.fsf@gnu.org> <20180521115357.GS3797@embecosm.com> <83y3gddl5q.fsf@gnu.org> <20180605185318.GE15881@embecosm.com> <1528233316.1703.31.camel@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1528233316.1703.31.camel@skynet.be> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00135.txt.bz2 * Philippe Waroquiers [2018-06-05 23:15:16 +0200]: > On Tue, 2018-06-05 at 19:53 +0100, Andrew Burgess wrote: > > > If we do need a keyword, how about "frame add"? > > > > Personally, I think 'add' is worse than 'create' - what's the frame > > being added too? But I do acknowledge that 'create' is not ideal > > either. > > > > I wonder if 'new' is better than 'create', maybe implies less "making > > something in the inferior"? Or how about, 'for' instead, like this: > > > > (gdb) frame for STACK-ADDR PC-ADDR > > If nothing is added or created or ..., > maybe you could also use one of: > (gdb) frame interpret STACK-ADDR PC-ADDR > or > (gdb) frame look STACK-ADDR PC-ADDR > or > (gdb) frame view STACK-ADDR PC-ADDR I like 'view', the docs could read: View a frame that is not part of GDB backtrace. The frame viewed has stack address @var{stack-addr}, and optionally, a program counter address of @var{pc-addr}. This is useful mainly if the chaining of stack frames has been damaged by a bug, making it impossible for @value{GDBN} to assign numbers properly to all frames. In addition, this can be useful when your program has multiple stacks and switches between them. Eli, how does this sound? Thanks, Andrew