From: Petr Tesarik <ptesarik@suse.cz>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org, jeffm@suse.com
Subject: Re: [PATCH v2 2/4] Make add-symbol-file's address argument optional
Date: Mon, 11 Jun 2018 16:50:00 -0000 [thread overview]
Message-ID: <20180611185048.2abca8d1@ezekiel.suse.cz> (raw)
In-Reply-To: <83in6pqrap.fsf@gnu.org>
On Mon, 11 Jun 2018 18:25:02 +0300
Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Petr Tesarik <ptesarik@suse.cz>
> > Cc: Petr Tesarik <ptesarik@suse.cz>, Jeff Mahoney <jeffm@suse.com>
> > Date: Mon, 11 Jun 2018 14:08:33 +0200
> >
> > The (first) .text section must be always specified as the second
> > non-option argument. The documentation states that GDB cannot
> > figure out this address by itself. This is true if the object file
> > was indeed relocated, but it is also confusing, because all other
> > sections can be omitted and will use the address provided by BFD.
> >
> > gdb/ChangeLog:
> > 2018-06-11 Petr Tesarik <ptesarik@suse.com>
> >
> > * symfile.c (add_symbol_file_command, _initialize_symfile): Do not
> > require the second argument. If omitted, load sections at the
> > addresses specified in the file.
> >
> > gdb/doc/ChangeLog:
> > 2018-06-11 Petr Tesarik <ptesarik@suse.com>
> >
> > * gdb.texinfo (Files): The address argument for "add-symbol-file"
> > is no longer mandatory.
> >
> > gdb/testsuite/ChangeLog:
> > 2018-06-11 Petr Tesarik <ptesarik@suse.com>
> >
> > * gdb.base/relocate.exp: Test add-symbol-file behavior when the
> > address argument is omitted.
>
> I have a feeling I already reviewed and approved this, but in case I
> didn't, I approve it now.
You did, but I resent the whole patch series again, improving the
changelog style and adding the help texts where necessary. I found it
better than fixing it up with a separate patch.
I'm sorry if that was confusing.
Petr T
next prev parent reply other threads:[~2018-06-11 16:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 12:08 [PATCH v2 0/4] Allow loading symbol files with an offset Petr Tesarik
2018-06-11 12:08 ` [PATCH v2 2/4] Make add-symbol-file's address argument optional Petr Tesarik
2018-06-11 15:25 ` Eli Zaretskii
2018-06-11 16:50 ` Petr Tesarik [this message]
2018-06-11 17:25 ` Eli Zaretskii
2018-06-26 2:14 ` Simon Marchi
2018-06-11 12:08 ` [PATCH v2 1/4] Add an optional offset option to the "symbol-file" command Petr Tesarik
2018-06-11 15:23 ` Eli Zaretskii
2018-06-26 2:02 ` Simon Marchi
2018-06-11 12:08 ` [PATCH v2 3/4] Make sure that sorting does not change section order Petr Tesarik
2018-06-26 2:37 ` Simon Marchi
2018-06-26 5:10 ` Petr Tesarik
2018-06-26 13:26 ` Simon Marchi
2018-06-11 12:23 ` [PATCH v2 4/4] Add an optional offset option to the "add-symbol-file" command Petr Tesarik
2018-06-26 2:52 ` Simon Marchi
2018-06-22 7:52 ` [PATCH v2 0/4] Allow loading symbol files with an offset Petr Tesarik
2018-06-26 2:58 ` Simon Marchi
2018-06-26 5:01 ` Petr Tesarik
2018-06-26 15:15 ` Simon Marchi
2018-06-26 15:23 ` Petr Tesarik
2018-06-27 12:14 ` [PATCH v3 " Petr Tesarik
2018-06-27 12:14 ` [PATCH v3 3/4] Make sure that sorting does not change section order Petr Tesarik
2018-06-27 12:14 ` [PATCH v3 1/4] Add an optional offset option to the "symbol-file" command Petr Tesarik
2018-06-27 12:14 ` [PATCH v3 2/4] Make add-symbol-file's address argument optional Petr Tesarik
2018-06-27 12:33 ` [PATCH v3 4/4] Add an optional offset option to the "add-symbol-file" command Petr Tesarik
2018-06-27 12:57 ` [PATCH v3 0/4] Allow loading symbol files with an offset Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611185048.2abca8d1@ezekiel.suse.cz \
--to=ptesarik@suse.cz \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jeffm@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).