From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4447 invoked by alias); 11 Jun 2018 16:50:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4425 invoked by uid 89); 11 Jun 2018 16:50:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=improving, states X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Jun 2018 16:50:53 +0000 Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D5764AF13; Mon, 11 Jun 2018 16:50:50 +0000 (UTC) Date: Mon, 11 Jun 2018 16:50:00 -0000 From: Petr Tesarik To: Eli Zaretskii Cc: gdb-patches@sourceware.org, jeffm@suse.com Subject: Re: [PATCH v2 2/4] Make add-symbol-file's address argument optional Message-ID: <20180611185048.2abca8d1@ezekiel.suse.cz> In-Reply-To: <83in6pqrap.fsf@gnu.org> References: <20180611120835.27343-1-ptesarik@suse.cz> <20180611120835.27343-3-ptesarik@suse.cz> <83in6pqrap.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00285.txt.bz2 On Mon, 11 Jun 2018 18:25:02 +0300 Eli Zaretskii wrote: > > From: Petr Tesarik > > Cc: Petr Tesarik , Jeff Mahoney > > Date: Mon, 11 Jun 2018 14:08:33 +0200 > > > > The (first) .text section must be always specified as the second > > non-option argument. The documentation states that GDB cannot > > figure out this address by itself. This is true if the object file > > was indeed relocated, but it is also confusing, because all other > > sections can be omitted and will use the address provided by BFD. > > > > gdb/ChangeLog: > > 2018-06-11 Petr Tesarik > > > > * symfile.c (add_symbol_file_command, _initialize_symfile): Do not > > require the second argument. If omitted, load sections at the > > addresses specified in the file. > > > > gdb/doc/ChangeLog: > > 2018-06-11 Petr Tesarik > > > > * gdb.texinfo (Files): The address argument for "add-symbol-file" > > is no longer mandatory. > > > > gdb/testsuite/ChangeLog: > > 2018-06-11 Petr Tesarik > > > > * gdb.base/relocate.exp: Test add-symbol-file behavior when the > > address argument is omitted. > > I have a feeling I already reviewed and approved this, but in case I > didn't, I approve it now. You did, but I resent the whole patch series again, improving the changelog style and adding the help texts where necessary. I found it better than fixing it up with a separate patch. I'm sorry if that was confusing. Petr T