From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13418 invoked by alias); 13 Jun 2018 23:22:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13393 invoked by uid 89); 13 Jun 2018 23:22:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=scanned, curiosity X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Jun 2018 23:22:31 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4412356141; Wed, 13 Jun 2018 19:22:30 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rqWTlhQTiCbP; Wed, 13 Jun 2018 19:22:30 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 127715604F; Wed, 13 Jun 2018 19:22:30 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5A3A6834FE; Wed, 13 Jun 2018 16:22:28 -0700 (PDT) Date: Wed, 13 Jun 2018 23:22:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 00/10] Remove standalone ptid functions Message-ID: <20180613232228.GA2166@adacore.com> References: <20180613215049.9691-1-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180613215049.9691-1-tom@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-06/txt/msg00347.txt.bz2 > This series removes the remaining standalone ptid functions in favor > of using methods on ptid_t. > > These patches were largely created by running a script. Looks like a very nice cleanup. I scanned through some of the patches, but not being the C++ expert in the group, I only did it out of curiosity for now. It looks fairly mechanical, as hinted by the fact that Tom said it was created by running a script. Anyone against the idea behind the change itself? Otherwise, I'd be inclined to allow Tom to self-review on that one. Thanks Tom! -- Joel