From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93029 invoked by alias); 18 Jun 2018 15:31:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92999 invoked by uid 89); 18 Jun 2018 15:31:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=submissions X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Jun 2018 15:31:25 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B0487562EB; Mon, 18 Jun 2018 11:31:21 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id E74XuJ-GRPsX; Mon, 18 Jun 2018 11:31:21 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 962B2562E9; Mon, 18 Jun 2018 11:31:21 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1A5F083D5A; Mon, 18 Jun 2018 11:31:21 -0400 (EDT) Date: Mon, 18 Jun 2018 15:31:00 -0000 From: Joel Brobecker To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/testsuite/ada] Fix number-of-bp test in bp_inlined_func.exp Message-ID: <20180618153121.GA2886@adacore.com> References: <20180617155221.kqev7e3bwxb5uxmq@localhost.localdomain> <20180618001158.GA2447@adacore.com> <68c97f70-34bc-1c6c-6241-ff98282173f3@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <68c97f70-34bc-1c6c-6241-ff98282173f3@suse.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2018-06/txt/msg00458.txt.bz2 > > - Can you also include the platform itself on which you did the > > testing? > > > > Done. > > > - One spelling issue -- see below. > > > > Fixed. > > Thanks for the review. You are welcome. In scanning quickly the commit, I noticed you said "x86_64" as the platform. No need to change anything now, but for your next submissions, it's better to include the OS as well. Typically, you'll see people say "tested on x86_64-linux" or "x86-windows", or "ppc-elf". Many times, the OS doesn't matter, but it's always good to have it, because the behavior does often depend on the OS. Thanks for the patch, though. GDB is the better for it, and this is what _really_ matters ;-). -- Joel